From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1HmXoQ-0001Mk-JV for mharc-grub-devel@gnu.org; Fri, 11 May 2007 12:17:46 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HmXoP-0001Mf-FS for grub-devel@gnu.org; Fri, 11 May 2007 12:17:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HmXoN-0001LM-VU for grub-devel@gnu.org; Fri, 11 May 2007 12:17:44 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HmXoN-0001LJ-PU for grub-devel@gnu.org; Fri, 11 May 2007 12:17:43 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HmXgw-00056p-30 for grub-devel@gnu.org; Fri, 11 May 2007 12:10:02 -0400 Received: from [192.168.10.6] (helo=aragorn) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1HmXgu-0006kJ-Hi for grub-devel@gnu.org; Fri, 11 May 2007 18:10:01 +0200 Received: from rmh by aragorn with local (Exim 4.63) (envelope-from ) id 1HmXiQ-0007ua-7a for grub-devel@gnu.org; Fri, 11 May 2007 18:11:34 +0200 Date: Fri, 11 May 2007 18:11:34 +0200 From: Robert Millan To: grub-devel@gnu.org Message-ID: <20070511161134.GA30158@aragorn> References: <20070511160314.GA30111@aragorn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070511160314.GA30111@aragorn> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: Genre and OS details not recognized. Subject: Re: [PATCH] grub-install for EFI X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2007 16:17:45 -0000 On Fri, May 11, 2007 at 06:03:14PM +0200, Robert Millan wrote: > diff -Nur grub2-1.95+20070507.old/conf/i386-efi.rmk grub2-1.95+20070507/conf/i386-efi.rmk > --- grub2-1.95+20070507.old/conf/i386-efi.rmk 2007-05-11 17:45:18.000000000 +0200 > +++ grub2-1.95+20070507/conf/i386-efi.rmk 2007-05-11 17:57:19.000000000 +0200 > @@ -6,7 +6,7 @@ > > # Utilities. > bin_UTILITIES = grub-mkimage > -#sbin_UTILITIES = grub-setup grub-mkdevicemap grub-probe > +sbin_UTILITIES = grub-mkdevicemap grub-probe grub-probe is needed to check partmap (so we don't have to assume gpt). grub-mkdevicemap is needed to create device.map, without which grub-probe won't work. > diff -Nur grub2-1.95+20070507.old/util/i386/efi/grub-install.in grub2-1.95+20070507/util/i386/efi/grub-install.in > --- grub2-1.95+20070507.old/util/i386/efi/grub-install.in 1970-01-01 01:00:00.000000000 +0100 > +++ grub2-1.95+20070507/util/i386/efi/grub-install.in 2007-05-11 18:00:44.000000000 +0200 Note: this grub-install.in is based on the i386/pc version. I tried to keep changes minimal, so if you diff them it'll produce readable output. One thing that I'm not sure about is the CLI inconsistency. Perhaps it shouldn't take the directory as a standalone parameter, and instead use --root-directory? > diff -Nur grub2-1.95+20070507.old/util/i386/pc/biosdisk.c grub2-1.95+20070507/util/i386/pc/biosdisk.c > --- grub2-1.95+20070507.old/util/i386/pc/biosdisk.c 2007-05-11 17:45:18.000000000 +0200 > +++ grub2-1.95+20070507/util/i386/pc/biosdisk.c 2007-05-11 17:57:19.000000000 +0200 > @@ -18,7 +18,7 @@ > * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. > */ > > -#include > +#include > #include > #include > #include > diff -Nur grub2-1.95+20070507.old/util/i386/pc/grub-probe.c grub2-1.95+20070507/util/i386/pc/grub-probe.c > --- grub2-1.95+20070507.old/util/i386/pc/grub-probe.c 2007-05-11 17:45:18.000000000 +0200 > +++ grub2-1.95+20070507/util/i386/pc/grub-probe.c 2007-05-11 17:57:19.000000000 +0200 > @@ -26,7 +26,7 @@ > #include > #include > #include > -#include > +#include > #include > #include Not really sure about these. Seems ugly, but biosdisk.h has the grub_util_biosdisk_get_grub_dev definition, which is not really i386/pc-specific. Also, note that powerpc needs them as well if we want update-grub to work there (haven't submitted this part, because it grub-probe on powerpc has other issues that I cannot debug). -- Robert Millan My spam trap is honeypot@aybabtu.com. Note: this address is only intended for spam harvesters. Writing to it will get you added to my black list.