All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] grub-install for EFI
Date: Fri, 11 May 2007 18:21:43 +0200	[thread overview]
Message-ID: <20070511162143.GA30863@aragorn> (raw)
In-Reply-To: <20070511161134.GA30158@aragorn>

On Fri, May 11, 2007 at 06:11:34PM +0200, Robert Millan wrote:
> 
> One thing that I'm not sure about is the CLI inconsistency.  Perhaps it
> shouldn't take the directory as a standalone parameter, and instead use
> --root-directory?

Or perhaps it should do like powerpc and check that /boot/grub is a mount
point?

# Find the partition at the right mount point.
install_device=`awk '$2 == '"\"$grubdir\""' { print $1 }' < /proc/mounts`
if test "x$install_device" = x; then
    echo "$grubdir must be a mount point."
    exit 1
fi

-- 
Robert Millan

My spam trap is honeypot@aybabtu.com.  Note: this address is only intended
for spam harvesters.  Writing to it will get you added to my black list.



  reply	other threads:[~2007-05-11 16:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-11 16:03 [PATCH] grub-install for EFI Robert Millan
2007-05-11 16:11 ` Robert Millan
2007-05-11 16:21   ` Robert Millan [this message]
2007-05-15 18:23     ` new patch Robert Millan
2007-05-15 20:22     ` [PATCH] grub-install for EFI Yoshinori K. Okuji
2007-05-16  6:17       ` Robert Millan
2007-05-17 19:17         ` Yoshinori K. Okuji
2007-05-15 20:20   ` Yoshinori K. Okuji
2007-05-16  6:31     ` Robert Millan
2007-05-16 15:38       ` grub-install for EFI (please test) Robert Millan
2007-05-15 20:16 ` [PATCH] grub-install for EFI Yoshinori K. Okuji
2007-05-16  6:25   ` Robert Millan
2007-05-17 19:18     ` Yoshinori K. Okuji
2007-05-18  6:37       ` Robert Millan
2007-05-18 18:27         ` Yoshinori K. Okuji
2007-05-19  9:43           ` Robert Millan
2007-05-19 17:21             ` Yoshinori K. Okuji
2007-05-20  7:19               ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070511162143.GA30863@aragorn \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.