All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Matt Mackall <mpm@selenic.com>,
	rlove@rlove.org, linux-kernel@vger.kernel.org,
	Ingo Molnar <mingo@elte.hu>, Dmitry Torokhov <dtor@mail.ru>
Subject: Re: 2.6.21-mm2: HDAPS? BUG: at kernel/mutex.c:311
Date: Fri, 11 May 2007 18:17:56 -0700	[thread overview]
Message-ID: <20070511181756.fa3762a1.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070511175335.092aa0af.akpm@linux-foundation.org>

On Fri, 11 May 2007 17:53:35 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> And indeed that's buggy - the non-debug version of spin_lock_mutex() is not
> irq-safe.
> 
> I'd say that's pretty dumb of the mutex interface, really.  Doing a
> mutex_trylock() should be OK from all contexts.

We can fix this in a low-impact fashion by making mutex_trylock() do a
spin_trylock() on mutex->wait_lock, no?


  reply	other threads:[~2007-05-12  1:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-12  0:21 2.6.21-mm2: HDAPS? BUG: at kernel/mutex.c:311 Matt Mackall
2007-05-12  0:53 ` Andrew Morton
2007-05-12  1:17   ` Andrew Morton [this message]
2007-05-12  5:12   ` Dmitry Torokhov
2007-05-12  5:45     ` Satyam Sharma
2007-05-14  2:57       ` Dmitry Torokhov
2007-05-14  3:40         ` Satyam Sharma
2007-05-26 20:43           ` Cédric Augonnet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070511181756.fa3762a1.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=dtor@mail.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mpm@selenic.com \
    --cc=rlove@rlove.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.