From: Dave Jones <davej@redhat.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>,
William Thompson <wt@electro-mechanical.com>,
Mark Lord <liml@rtr.ca>,
linux-kernel@vger.kernel.org,
IDE/ATA development list <linux-ide@vger.kernel.org>,
albertcc@tw.ibm.com
Subject: Re: [PATCH] libata: fallback to the other IDENTIFY on device error, take#2
Date: Sun, 13 May 2007 14:13:44 -0400 [thread overview]
Message-ID: <20070513181344.GG27604@redhat.com> (raw)
In-Reply-To: <46474FD8.2070100@gmail.com>
On Sun, May 13, 2007 at 07:50:16PM +0200, Tejun Heo wrote:
> > Otherwise, as Jeff mentions, you're doing a redundant assignment
> > in the else branch.
>
> Hmmm... I'm feeling very dense today. At that point, class is either
> ATA_DEV_ATA or ATA_DEV_ATAPI. The if-else clause tries to flip between
> the two.
>
> 1. if class == ATA_DEV_ATA, the 'if' test succeeds and "class =
> ATA_DEV_ATAPI" runs, so it flips correctly.
>
> 2. if class == ATA_DEV_ATAPI, the 'if' test fails and "class =
> ATA_DEV_ATA" runs, so it flips correctly.
>
> What am I missing here? Feel free to scream at me and hammer me into
> senses. :-)
actually, I think I'm denser today. Ignore that last mail.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-05-13 18:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-27 17:52 2.6.20 libata cdrom William Thompson
2007-04-30 10:22 ` Tejun Heo
2007-04-30 20:21 ` William Thompson
2007-05-01 4:32 ` Tejun Heo
2007-05-01 12:17 ` William Thompson
2007-05-01 13:04 ` Mark Lord
2007-05-01 13:18 ` William Thompson
2007-05-01 13:24 ` Mark Lord
2007-05-01 13:36 ` Alan Cox
2007-05-01 13:40 ` Tejun Heo
2007-05-01 13:51 ` Mark Lord
2007-05-01 14:19 ` Jeff Garzik
2007-05-01 14:23 ` Mark Lord
2007-05-01 14:28 ` Alan Cox
2007-05-01 17:21 ` William Thompson
2007-05-07 16:42 ` [PATCH] libata: fallback to the other IDENTIFY on device error Tejun Heo
2007-05-07 17:34 ` William Thompson
2007-05-07 18:05 ` William Thompson
2007-05-08 8:02 ` Tejun Heo
2007-05-10 0:08 ` Jeff Garzik
2007-05-11 12:35 ` [PATCH] libata: fallback to the other IDENTIFY on device error, take#2 Tejun Heo
2007-05-11 22:10 ` Jeff Garzik
2007-05-11 22:10 ` Jeff Garzik
2007-05-13 12:57 ` Tejun Heo
2007-05-13 16:13 ` Dave Jones
2007-05-13 17:50 ` Tejun Heo
2007-05-13 18:13 ` Dave Jones [this message]
2007-05-01 18:11 ` 2.6.20 libata cdrom Bartlomiej Zolnierkiewicz
2007-05-01 12:54 ` Mark Lord
2007-05-01 12:55 ` Mark Lord
2007-05-01 13:32 ` Tejun Heo
2007-05-01 13:41 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070513181344.GG27604@redhat.com \
--to=davej@redhat.com \
--cc=albertcc@tw.ibm.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wt@electro-mechanical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.