From: Andrew Morton <akpm@linux-foundation.org>
To: Gabor Burjan <buga@buvoshetes.hu>
Cc: Patrick McHardy <kaber@trash.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: kernel oops after unloading nf_conntrack_netbios_ns_module
Date: Mon, 14 May 2007 15:14:34 -0700 [thread overview]
Message-ID: <20070514151434.a48fa153.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070514071611.GA8864@odin.sis.hu>
On Mon, 14 May 2007 09:16:11 +0200
Gabor Burjan <buga@buvoshetes.hu> wrote:
> On Sat, May 12, 2007 at 05:05:51PM +0200, Patrick McHardy wrote:
> > Gabor Burjan wrote:
> > > EIP is at destroy_conntrack+0x52/0x127 [nf_conntrack]
> > >
> > >>>nmblookup <existing_netbios_name>
> > >>>cat /proc/net/ip_conntrack
> > >>>
> > >>>sleep 3
> > >>>
> > >>>rmmod nf_conntrack_netbios_ns
> >
> > Thanks for the report and good testcase, the crash can only happen with
> > a sleep of >= 3s after the last nmblookup packet was sent.
> >
> > Can you try if this patch fixes it please?
>
> Yes, it fixes the problem.
Just speaking generally, rather than about this particualr patch...
Gabor did quite an amount of valuable work here: tested a 2.6.20.x kernel,
developed a test case for reproducing the bug, reported it all quite
exhaustively, tested the resulting patch.
The least we can do in return is to put a big fat "thanks" in the changelog
when the fix gets merged.
> Thank you,
No - thank _you_.
prev parent reply other threads:[~2007-05-14 22:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 9:06 kernel oops after unloading nf_conntrack_netbios_ns_module Gabor Burjan
2007-05-10 10:34 ` Andrew Morton
2007-05-10 11:01 ` Gabor Burjan
2007-05-12 15:05 ` Patrick McHardy
2007-05-14 7:16 ` Gabor Burjan
2007-05-14 22:14 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070514151434.a48fa153.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=buga@buvoshetes.hu \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.