Re: [PATCH] lighweight VM Exit

[Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>]

On Mon, May 14, 2007 at 06:14:31PM +0300, Avi Kivity wrote:
> Dong, Eddie wrote:
> > OK, how about this patch which further reduce the light weight VM Exit
> > MSR save/restore?
> >
> >
> > diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c
> > index 1288cff..ef96fae 100644
> > --- a/drivers/kvm/kvm_main.c
> > +++ b/drivers/kvm/kvm_main.c
> > @@ -1596,6 +1596,30 @@ void kvm_resched(struct kvm_vcpu *vcpu)
> >  }
> >  EXPORT_SYMBOL_GPL(kvm_resched);
> >  
> > +void load_msrs_select(struct vmx_msr_entry *e, int bitmap)
> > +{
> > +	unsigned long nr;
> > +
> > +	while (bitmap) {
> > +		nr = __ffs(bitmap);
> > +		clear_bit(nr,&bitmap);
> > +		wrmsrl(e[nr].index, e[nr].data);
> > +	}
> > +}
> > +EXPORT_SYMBOL_GPL(load_msrs_select);

Exported symbols should have names with a meaningfull prefix and
a kerneldoc comment describing them.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/