From: Andrew Morton <akpm@linux-foundation.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Jean Delvare <khali@linux-fr.org>,
i2c@lm-sensors.org, linux-kernel@vger.kernel.org,
Alessandro Zummo <alessandro.zummo@towertech.it>
Subject: Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder
Date: Mon, 14 May 2007 23:34:01 -0700 [thread overview]
Message-ID: <20070514233401.cfeed9b0.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070513073906.24149.1292.stgit@trillian.secretlab.ca>
On Sun, 13 May 2007 01:43:42 -0600 Grant Likely <grant.likely@secretlab.ca> wrote:
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> ---
>
> Here is the 3rd iteration with the following changes:
> - Modified to be an i2c "new style" driver based on David Brownell's work
> - uses the new prototype for i2c_smbus_read_i2c_block_data() for block data
> reads instead of a single byte at a time.\
What new prototype for i2c_smbus_read_i2c_block_data()?
drivers/i2c/chips/ds1682.c: In function 'ds1682_show':
drivers/i2c/chips/ds1682.c:75: warning: passing argument 3 of 'i2c_smbus_read_i2c_block_data' makes pointer from integer without a cast
drivers/i2c/chips/ds1682.c:75: error: too many arguments to function 'i2c_smbus_read_i2c_block_data'
drivers/i2c/chips/ds1682.c: In function 'ds1682_eeprom_read': drivers/i2c/chips/ds1682.c:165: warning: passing argument 3 of 'i2c_smbus_read_i2c_block_data' makes pointer from integer without a cast
drivers/i2c/chips/ds1682.c:165: error: too many arguments to function 'i2c_smbus_read_i2c_block_data'
next prev parent reply other threads:[~2007-05-15 6:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-13 7:43 [PATCH] Add driver for Dallas DS1682 elapsed time recorder Grant Likely
2007-05-14 8:56 ` Jean Delvare
2007-05-14 17:29 ` Grant Likely
2007-05-14 19:05 ` Jean Delvare
2007-05-15 0:46 ` Andrew Morton
2007-05-15 6:34 ` Andrew Morton [this message]
2007-05-15 7:25 ` Grant Likely
2007-05-15 13:14 ` Jean Delvare
-- strict thread matches above, loose matches on Subject: below --
2007-05-07 20:45 Grant Likely
2007-05-10 11:48 ` Jean Delvare
2007-05-10 12:49 ` Alessandro Zummo
2007-05-10 20:37 ` Grant Likely
2007-05-11 10:23 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070514233401.cfeed9b0.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alessandro.zummo@towertech.it \
--cc=grant.likely@secretlab.ca \
--cc=i2c@lm-sensors.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.