Re: [DTC PATCH] Remove overreaching semantic tests.

[David Gibson <david@gibson.dropbear.id.au>]

On Mon, May 14, 2007 at 10:51:51AM -0500, Scott Wood wrote:
> David Gibson wrote:
> > On Fri, May 11, 2007 at 12:55:54PM -0500, Scott Wood wrote:
> >>I wouldn't be opposed to keeping these tests around if there were a
> >>command line option that cleanly separates the errors/warnings into
> >>classes such as structural, semantic-missing, semantic-broken, etc.
> > 
> > Exactly - which is why I really don't want to simply tear out this
> > checking code.  I've never gotten around to reworking the
> > error/warning system so it can sensibly divide things into such
> > classes, and keep detecting further warnings after picking up some
> > non-fatal ones and so forth.
> > 
> > I'd much prefer you just disable these tests for now, either by
> > commenting code out, or removing calls to checking functions.  That
> > will make it easier to optionally reinstate later.
> 
> Well, I figured the code would still be there in git, so getting it back 
> wouldn't be too hard.  I can submit a patch that hides it behind a 
> --warn-missing (or whatever) option, though.

I'd prefer that, thank you.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson