All of lore.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Alexey Starikovskiy <aystarik@gmail.com>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] ACPI: Remove possible recursion from thermal driver
Date: Tue, 15 May 2007 16:26:02 -0400	[thread overview]
Message-ID: <200705151626.02687.lenb@kernel.org> (raw)
In-Reply-To: <8f8ff01d0705142254r97c8dd9h8aa82eb67e44ae5f@mail.gmail.com>


> --- a/drivers/acpi/thermal.c
> +++ b/drivers/acpi/thermal.c
> @@ -1106,7 +1106,6 @@ static void acpi_thermal_notify(acpi_handle handle, u32 event, void *data)
> 		break;
> 	case ACPI_THERMAL_NOTIFY_THRESHOLDS:
> 		acpi_thermal_get_trip_points(tz);
>-		acpi_thermal_check(tz);
> 		acpi_bus_generate_event(device, event, 0);
> 		break;
> 	case ACPI_THERMAL_NOTIFY_DEVICES:

I don't think we can do this.
When the thresholds change, there must be a check to compare the temperature
with the thresholds -- otherwise what good was it to change the thresholds?

-Len

  reply	other threads:[~2007-05-15 20:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-15  5:54 [PATCH] ACPI: Remove possible recursion from thermal driver Alexey Starikovskiy
2007-05-15 20:26 ` Len Brown [this message]
2007-05-16  2:19   ` Alexey Starikovskiy
2007-05-17 18:23     ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200705151626.02687.lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=aystarik@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.