From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: gmail_ati <henry.su.ati@gmail.com>
Cc: henry su <henry.su@amd.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH]add the IDE device ID for ATI SB700
Date: Wed, 16 May 2007 00:37:03 +0200 [thread overview]
Message-ID: <200705160037.03542.bzolnier@gmail.com> (raw)
In-Reply-To: <00c901c79638$bad8e4e0$6400a8c0@henry>
Hi,
On Monday 14 May 2007, gmail_ati wrote:
> From: henry.su.ati@gmail.com
> add the IDE device ids to atiixp_pci_tbl struct in atiixp.c for ATI SB700.
> Signed-off-by: Luugi Marsan <luugi.marsan@amd.com>
This patch is somehow missing the chunk adding PCI_DEVICE_ID_ATI_IXP700_IDE
define to <linux/pci_ids.h> and thus makes atiixp.c fail to compile.
Please resend the complete patch.
PS your mailer seems to encode patches in some strange way (whitespaces are
mangled and saved email contained MIME encoded text instead of plain-text) so
I had to apply this change by hand. Not really a problem for this particular
patch ;) but definitively something needing fixing.
Thanks,
Bart
> -----------------------------------------------------
> diff -Nur linux-2.6.21.1.org/drivers/ide/pci/atiixp.c linux-2.6.21.1/drivers/ide/pci/atiixp.c
> --- linux-2.6.21.1.org/drivers/ide/pci/atiixp.c 2007-05-13 04:47:25.000000000 +0800
> +++ linux-2.6.21.1/drivers/ide/pci/atiixp.c 2007-05-13 05:14:08.000000000 +0800
> @@ -353,6 +353,7 @@
> { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP300_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
> { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP400_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
> { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1},
> + { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1},
> { 0, },
> };
> MODULE_DEVICE_TABLE(pci, atiixp_pci_tbl);
next parent reply other threads:[~2007-05-16 0:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <00c901c79638$bad8e4e0$6400a8c0@henry>
2007-05-15 22:37 ` Bartlomiej Zolnierkiewicz [this message]
2007-05-16 3:38 ` [PATCH]add the IDE device ID for ATI SB700 Henry Su
2007-05-16 7:32 ` Henry Su
2007-05-23 9:26 ` Henry Su
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705160037.03542.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=henry.su.ati@gmail.com \
--cc=henry.su@amd.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.