From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1HoD8m-0005Yi-In for mharc-grub-devel@gnu.org; Wed, 16 May 2007 02:37:40 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HoD8k-0005YH-Nz for grub-devel@gnu.org; Wed, 16 May 2007 02:37:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HoD8i-0005Xg-Qy for grub-devel@gnu.org; Wed, 16 May 2007 02:37:37 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HoD8i-0005Xd-IW for grub-devel@gnu.org; Wed, 16 May 2007 02:37:36 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HoD0j-0008Gp-Gv for grub-devel@gnu.org; Wed, 16 May 2007 02:29:22 -0400 Received: from [192.168.10.6] (helo=aragorn) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1HoD0e-0005Zu-9t for grub-devel@gnu.org; Wed, 16 May 2007 08:29:16 +0200 Received: from rmh by aragorn with local (Exim 4.63) (envelope-from ) id 1HoD2R-00060t-AZ for grub-devel@gnu.org; Wed, 16 May 2007 08:31:07 +0200 Date: Wed, 16 May 2007 08:31:07 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20070516063107.GC22567@aragorn> References: <20070511160314.GA30111@aragorn> <20070511161134.GA30158@aragorn> <200705152220.42031.okuji@enbug.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200705152220.42031.okuji@enbug.org> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: Genre and OS details not recognized. Subject: Re: [PATCH] grub-install for EFI X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 May 2007 06:37:39 -0000 On Tue, May 15, 2007 at 10:20:41PM +0200, Yoshinori K. Okuji wrote: > > > > One thing that I'm not sure about is the CLI inconsistency. Perhaps it > > shouldn't take the directory as a standalone parameter, and instead use > > --root-directory? > > Consistency is important, but it is not a must, as long as the user can easily > guess the difference. In principle, you should respect consistency, but > should not blindly believe in it. So if you think it is reasonable to make > difference, you can. Otherwise, don't. Ok. My last version is mostly consistent (/boot/grub path is a default, and can be overriden the same way), the difference being that it doesn't take any non-flag argument. But I think this difference is reasonable, specially considering that i386/pc/grub-install and powerpc/grub-install already differ on this part. > > Not really sure about these. Seems ugly, but biosdisk.h has the > > grub_util_biosdisk_get_grub_dev definition, which is not really > > i386/pc-specific. Also, note that powerpc needs them as well if we > > want update-grub to work there (haven't submitted this part, because it > > grub-probe on powerpc has other issues that I cannot debug). > > If it is not specific to i386-pc, it should be moved to somewhere else. Will do. Thanks, -- Robert Millan My spam trap is honeypot@aybabtu.com. Note: this address is only intended for spam harvesters. Writing to it will get you added to my black list.