From: Simon Horman <horms@verge.net.au>
To: Ian Campbell <Ian.Campbell@xensource.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [Patch v3] static, __init and __initdata symbols in machine_kexec.c
Date: Wed, 16 May 2007 18:07:30 +0900 [thread overview]
Message-ID: <20070516090728.GA11162@verge.net.au> (raw)
In-Reply-To: <1179303396.26437.78.camel@localhost.localdomain>
On Wed, May 16, 2007 at 09:16:36AM +0100, Ian Campbell wrote:
> On Wed, 2007-05-16 at 15:49 +0900, Simon Horman wrote:
> > Some symbols in machine_kexec.c really ought to be static and,
> > marked __init or __initdata.
>
> Applied, thanks.
Sorry, I was a bit hasty with sending in this patch :(
As per the subseqent v4, I discovered that xen_hypervisor_res and
xen_phys_cpus really ought not to be __initdata because they get
inserted into resource_iomem, which is accessed after init. Should I
send in an additional patch to reverse that part of the change?
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
next prev parent reply other threads:[~2007-05-16 9:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 6:49 static and __init symbols in machine_kexec.c Simon Horman
2007-05-16 6:49 ` [Patch v2] " Simon Horman
2007-05-16 7:21 ` Keir Fraser
2007-05-16 7:31 ` Simon Horman
2007-05-16 6:49 ` [Patch v3] static, __init and __initdata " Simon Horman, Keir Fraser
2007-05-16 6:49 ` [Patch v4] " Simon Horman, Keir Fraser
2007-05-16 8:16 ` [Patch v3] " Ian Campbell
2007-05-16 9:07 ` Simon Horman [this message]
2007-05-16 9:11 ` Keir Fraser
2007-05-16 9:32 ` Simon Horman
2007-05-16 7:58 ` [Patch v2] static and __init " Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070516090728.GA11162@verge.net.au \
--to=horms@verge.net.au \
--cc=Ian.Campbell@xensource.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.