From: Christoph Hellwig <hch@lst.de>
To: Ishizaki Kou <kou.ishizaki@toshiba.co.jp>
Cc: linuxppc-dev@ozlabs.org, hch@lst.de, cbe-oss-dev@ozlabs.org
Subject: Re: [PATCH] fix celleb link failure
Date: Wed, 16 May 2007 12:37:52 +0200 [thread overview]
Message-ID: <20070516103752.GA22383@lst.de> (raw)
In-Reply-To: <200705160714.l4G7EW9b014697@toshiba.co.jp>
On Wed, May 16, 2007 at 04:14:31PM +0900, Ishizaki Kou wrote:
> NACK.
>
> Thanks for pointing it out. But this fix is still wrong.
> early_serial_txx9_setup is availble if CONFIG_SERIAL_TXX9=y.
You're right. I've updated the patch to only build scc_sio.o
only if CONFIG_SERIAL_TXX9 is set. This works because
CONFIG_SERIAL_TXX9 can't be modular currently.
> > -#ifdef CONFIG_SERIAL_TXX9_CONSOLE
> > req.membase = ioremap(req.mapbase, 0x24);
> > -#endif
> > req.irq = irq_create_of_mapping(irq.controller,
> > irq.specifier, irq.size);
> > req.flags |= UPF_IOREMAP | UPF_BUGGY_UART
> /*HAVE_CTS_LINE*/;
>
> And we need these #ifdef and #endif.
Ok, dropped.
Index: linux-2.6.20/arch/powerpc/platforms/celleb/Makefile
===================================================================
--- linux-2.6.20.orig/arch/powerpc/platforms/celleb/Makefile 2007-05-16 11:36:28.000000000 +0200
+++ linux-2.6.20/arch/powerpc/platforms/celleb/Makefile 2007-05-16 11:36:41.000000000 +0200
@@ -4,5 +4,5 @@ obj-y += interrupt.o iommu.o setup.o
obj-$(CONFIG_SMP) += smp.o
obj-$(CONFIG_PPC_UDBG_BEAT) += udbg_beat.o
-obj-$(CONFIG_HAS_TXX9_SERIAL) += scc_sio.o
+obj-$(CONFIG_SERIAL_TXX9) += scc_sio.o
obj-$(CONFIG_SPU_BASE) += spu_priv1.o
next prev parent reply other threads:[~2007-05-16 10:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-15 13:09 [PATCH] fix celleb link failure Christoph Hellwig
2007-05-16 7:14 ` Ishizaki Kou
2007-05-16 10:37 ` Christoph Hellwig [this message]
2007-05-21 7:28 ` Ishizaki Kou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070516103752.GA22383@lst.de \
--to=hch@lst.de \
--cc=cbe-oss-dev@ozlabs.org \
--cc=kou.ishizaki@toshiba.co.jp \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.