From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HoILw-0003C1-7l
	for qemu-devel@nongnu.org; Wed, 16 May 2007 08:11:36 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HoILs-0003Bn-HU
	for qemu-devel@nongnu.org; Wed, 16 May 2007 08:11:35 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HoILs-0003Bk-EQ
	for qemu-devel@nongnu.org; Wed, 16 May 2007 08:11:32 -0400
Received: from phoenix.bawue.net ([193.7.176.60] helo=mail.bawue.net)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1HoIDs-0004QI-Jw
	for qemu-devel@nongnu.org; Wed, 16 May 2007 08:03:16 -0400
Date: Wed, 16 May 2007 13:01:04 +0100
Subject: Re: [Qemu-devel] [PATCH, MIPS64] dmult & dmultu emulation
Message-ID: <20070516120104.GE22169@networkno.de>
References: <20070515204903.GA19494@amd64.aurel32.net>
	<200705152207.01210.paul@codesourcery.com>
	<20070516000014.GA6169@amd64.aurel32.net>
	<20070516092038.GA15853@amd64.aurel32.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070516092038.GA15853@amd64.aurel32.net>
From: Thiemo Seufer <ths@networkno.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org

Aurelien Jarno wrote:
> On Wed, May 16, 2007 at 02:00:14AM +0200, Aurelien Jarno wrote:
> > On Tue, May 15, 2007 at 10:07:00PM +0100, Paul Brook wrote:
> > > > The patch below fixes the emulation of dmult and dmultu by doing a real
> > > > 64x64 -> 128 multiplication.
> > > 
> > > Can we share the implementation between targets please. We already have an 
> > > implementation of mul64 in target-i386/helper.c.
> > > 
> > > I've no real preference which implementation we use, I just don't want there 
> > > to be several of them.
> > 
> > Ok, please find an updated patch below. The multiplications functions
> > are in mul64.c and are now shared by the i386 and mips targets.
> > 
> 
> 03:40 < pbrook> aurel32: I think you've got a sign mismatch in your target-i386/helper.c patch. You've replaced imul64 with mulu64.
> 
> I confirm I have made a mistake here, please find an updated patch
> below.

I moved the file to host-utils.c, there may be more such functions
needed some day.


Thiemo