[PATCH] mkuboot.sh: quit elegantly on not finding mkimage

[PATCH] mkuboot.sh: quit elegantly on not finding mkimage

[nishanth menon]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

Hi All,
A tiny patch: when mkimage is not found return 1 instead of 0. helps
to ensure that the make uImage fails if mkimage is not in path.

Could not find a vgers list for scripts.. hence posting here..

Regards,
Nishanth menon

[-- Attachment #2: 01-mkuboot.sh-quit-elegantly-on-not-finding-mkimage.patch --]
[-- Type: application/octet-stream, Size: 841 bytes --]

mkuboot.sh: quit elegantly on not finding mkimage

Signed-off-by: Nishanth Menon <menon.nishanth@gmail.com>

---
commit 4c97cdc4985a397cffaf48db2302802d043fbea8
tree 6359dcd6751118c5c05c5b87aa5deb92f9716356
parent d72e018b77f5b513ab05a59e02ac07260215f79c
author Nishanth Menon <menon.nishanth@gmail.com> Tue, 08 May 2007 18:56:05 -0500
committer Nishanth Menon <menon.nishanth@gmail.com> Tue, 08 May 2007 18:56:05 -0500

 scripts/mkuboot.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/mkuboot.sh b/scripts/mkuboot.sh
index 2e3d3cd..446739c 100755
--- a/scripts/mkuboot.sh
+++ b/scripts/mkuboot.sh
@@ -11,7 +11,7 @@ if [ -z "${MKIMAGE}" ]; then
 	if [ -z "${MKIMAGE}" ]; then
 		# Doesn't exist
 		echo '"mkimage" command not found - U-Boot images will not be built' >&2
-		exit 0;
+		exit 1;
 	fi
 fi
 

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] mkuboot.sh: quit elegantly on not finding mkimage

[tony]

* nishanth menon <menon.nishanth@gmail.com> [070508 17:18]:
> Hi All,
> A tiny patch: when mkimage is not found return 1 instead of 0. helps
> to ensure that the make uImage fails if mkimage is not in path.
> 
> Could not find a vgers list for scripts.. hence posting here..

You should post this to LKML as u-boot is cross platform. Or send it
to the u-boot maintainer to send it to LKML.

Tony

Re: [PATCH] mkuboot.sh: quit elegantly on not finding mkimage

[George G. Davis]

On May 16, 2007, at 8:18 AM, tony@atomide.com wrote:

> * nishanth menon <menon.nishanth@gmail.com> [070508 17:18]:
>> Hi All,
>> A tiny patch: when mkimage is not found return 1 instead of 0. helps
>> to ensure that the make uImage fails if mkimage is not in path.

I submitted a fix for this to LKML long ago and the PPC folks shot it  
down
because they want silent failure for the case where mkimage is not  
found.

--
Regards,
George

>>
>> Could not find a vgers list for scripts.. hence posting here..
>
> You should post this to LKML as u-boot is cross platform. Or send it
> to the u-boot maintainer to send it to LKML.
>
> Tony
>
> _______________________________________________
> Linux-omap-open-source mailing list
> Linux-omap-open-source@linux.omap.com
> http://linux.omap.com/mailman/listinfo/linux-omap-open-source

Re: [PATCH] mkuboot.sh: quit elegantly on not finding mkimage

[nishanth menon]

On 5/16/07, George G. Davis <gdavis@mvista.com> wrote:
> I submitted a fix for this to LKML long ago and the PPC folks shot it
> down
> because they want silent failure for the case where mkimage is not
> found.
Thanks George. Got the thread:
http://lkml.org/lkml/2005/3/13/33

And the counter argument here:
http://www.uwsg.iu.edu/hypermail/linux/kernel/0503.1/1002.html

Regards,
Nishanth Menon