From: Stefan Roese <sr@denx.de>
To: Eugene Surovegin <ebs@ebshome.net>
Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] ibm_emac: Correctly detect old link speed
Date: Wed, 16 May 2007 20:44:47 +0200 [thread overview]
Message-ID: <200705162044.47776.sr@denx.de> (raw)
In-Reply-To: <20070516173002.GA22331@gate.ebshome.net>
On Wednesday 16 May 2007, Eugene Surovegin wrote:
> On Wed, May 16, 2007 at 01:00:08PM +0200, Stefan Roese wrote:
> > This patch fixes a bug where the link speed change was not
> > detected correctly. This occured on a 440SPe (EMAC4) system
> > where the old link speed was 100Mbps and the new link speed
> > is 1000Mbps.
>
> Good catch, Stefan. Unfortunately, I have to NACK your patch - you
> broke non EMAC4 builds.
Yes, you're right of course.
> Correct fix is just to remove EMAC_MR1_MF_1000GPCS from the first
> if condition.
Yep.
> I'll send correct fix shortly along with other queued patches.
Thanks.
Best regards,
Stefan
next prev parent reply other threads:[~2007-05-16 18:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 11:00 [PATCH] ibm_emac: Correctly detect old link speed Stefan Roese
2007-05-16 11:00 ` Stefan Roese
2007-05-16 17:30 ` Eugene Surovegin
2007-05-16 18:44 ` Stefan Roese [this message]
2007-05-21 5:13 ` David Gibson
2007-05-21 5:13 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705162044.47776.sr@denx.de \
--to=sr@denx.de \
--cc=ebs@ebshome.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.