From: Tony Lindgren <tony@atomide.com>
To: "Syed Mohammed, Khasim" <x0khasim@ti.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] TWL4030 Keypad driver - incorporated review comments
Date: Wed, 16 May 2007 15:04:51 -0700 [thread overview]
Message-ID: <20070516220450.GE15281@atomide.com> (raw)
In-Reply-To: <9C23CDD79DA20A479D4615857B2E2C470810AC@dlee13.ent.ti.com>
* Syed Mohammed, Khasim <x0khasim@ti.com> [070516 10:33]:
>
> >while testing the TWL4030 keypad driver I found that it causes I2C errors,
> >but Nishant's "FIFO Handling support and broken hw workaround" patch fixes
> >the problem. So, the problem is not in the keypad driver itself
> >but it's in i2c-omap driver. Tony, consider pushing the I2C fix too.
>
> Yes, it does fix I2C issues as it adds FIFO support to existing I2C driver. Tony please consider this patch.
>
> Let me know if you have any comments, I can fix them along with TWLKEYPAD patch.
Pushing today.
Tony
prev parent reply other threads:[~2007-05-16 22:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 19:40 [PATCH] TWL4030 Keypad driver - incorporated review comments Syed Mohammed, Khasim
2007-05-11 0:04 ` nishanth menon
2007-05-11 0:19 ` Syed Mohammed, Khasim
2007-05-11 1:00 ` Nishanth Menon
2007-05-12 0:50 ` nishanth menon
2007-05-16 16:13 ` tony
2007-05-16 16:16 ` Syed Mohammed, Khasim
2007-05-16 16:19 ` tony
2007-05-16 16:35 ` Syed Mohammed, Khasim
2007-05-16 17:19 ` Dmitry Krivoschekov
2007-05-16 17:31 ` Syed Mohammed, Khasim
2007-05-16 22:04 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070516220450.GE15281@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=x0khasim@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.