From: Petr Baudis <pasky@suse.cz>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH] git-gui: Build even if tclsh is not available
Date: Thu, 17 May 2007 04:36:14 +0200 [thread overview]
Message-ID: <20070517023614.GL4489@pasky.or.cz> (raw)
In-Reply-To: <20070517021858.GY3141@spearce.org>
On Thu, May 17, 2007 at 04:18:58AM CEST, Shawn O. Pearce wrote:
> I have a couple of problems with the patch as-is. The first is
> of course that the patch needs to be split into two; one patch for
> the git-gui subdirectory itself and one for git.git.
Hmm, why? It's an atomic change, one part doesn't make sense without the
other.
> My other problem is
>
> > ifeq ($(findstring $(MAKEFLAGS),s),s)
> > @@ -92,7 +92,7 @@ install: all
> > $(INSTALL) git-gui '$(DESTDIR_SQ)$(gitexecdir_SQ)'
> > $(foreach p,$(GITGUI_BUILT_INS), rm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' && ln '$(DESTDIR_SQ)$(gitexecdir_SQ)/git-gui' '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' ;)
> > $(INSTALL) -d -m755 '$(DESTDIR_SQ)$(libdir_SQ)'
> > - $(INSTALL) -m644 lib/tclIndex '$(DESTDIR_SQ)$(libdir_SQ)'
> > + [ ! -e lib/tclIndex ] || $(INSTALL) -m644 lib/tclIndex '$(DESTDIR_SQ)$(libdir_SQ)'
> > $(foreach p,$(ALL_LIBFILES), $(INSTALL) -m644 $p '$(DESTDIR_SQ)$(libdir_SQ)' ;)
>
> git-gui won't work if lib/tclIndex is missing or invalid. So not
> installing it means we should just disable git-gui entirely.
Aha, ouch - I understood that it is only an optimization. :-(
So AIUI, there are several possibilities:
(i) Makefile will autodecide on whether git-gui will be
built+installed or not
(ii) ./configure will, people not using configure and building on
servers will be left to tweak config manually
(iii) ./configure will, git-gui will default to not to be built and
people not using configure and wanting git-gui will be left to tweak
config manually
I suspect that (ii) will be chosen, and even though I don't like it
*personally* I guess it's the most reasonable approach for the general
public. I didn't know that tclIndex is vital for git-gui when I
submitted the patch, the /Makefile comment suggests otherwise.
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Ever try. Ever fail. No matter. // Try again. Fail again. Fail better.
-- Samuel Beckett
next prev parent reply other threads:[~2007-05-17 2:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-17 2:06 [PATCH] git-gui: Build even if tclsh is not available Petr Baudis
2007-05-17 2:14 ` Petr Baudis
2007-05-17 2:18 ` Shawn O. Pearce
2007-05-17 2:36 ` Petr Baudis [this message]
2007-05-17 2:49 ` Shawn O. Pearce
2007-05-17 22:16 ` Shawn O. Pearce
-- strict thread matches above, loose matches on Subject: below --
2007-05-17 2:04 Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070517023614.GL4489@pasky.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.