Re: [RFC,PATCH 4/14] knfsd: has_wspace per transport

[Greg Banks <gnb@sgi.com>]

On Wed, May 16, 2007 at 05:10:53PM -0400, J. Bruce Fields wrote:
> On Thu, May 17, 2007 at 05:22:11AM +1000, Greg Banks wrote:
> > +	set_bit(SOCK_NOSPACE, &svsk->sk_sock->flags);
> > +	if (required*2 > wspace) {
> > +		/* Don't enqueue while not enough space for reply */
> > +		dprintk("svc: socket %p  no space, %d*2 > %d, not enqueued\n",
> > +			svsk->sk_sk, required, wspace);
> > +		return 0;
> > +	}
> > +	clear_bit(SOCK_NOSPACE, &svsk->sk_sock->flags);
> > +	return 1;
> > +}
> 
> So, this is just my ignorance--why do the set and clear of SOCK_NOSPACE
> need to be ordered in the way they are?  (Why not just set once inside
> the if clause?)

I can't see a good reason for it, but I'm trying to minimise
perturbations to the logic.

Greg.
-- 
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
Apparently, I'm Bedevere.  Which MPHG character are you?
I don't speak for SGI.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs