All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Dmitry Krivoschekov <dmitry.krivoschekov@gmail.com>
Cc: Paul Walmsley <paul@pwsan.com>, linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH 0/5] Clean up omap24xx.h symbolic constants
Date: Thu, 17 May 2007 10:43:28 -0700	[thread overview]
Message-ID: <20070517174328.GB8556@atomide.com> (raw)
In-Reply-To: <464C123F.6050005@gmail.com>

* Dmitry Krivoschekov <dmitry.krivoschekov@gmail.com> [070517 01:29]:
> Hello,
> 
> Paul Walmsley wrote:
> > So, to continue the example above, the OMAP24XX_SDRC_BASE constant
> > will be removed, and replaced with two defines: OMAP2420_SDRC_BASE and
> > OMAP243X_SDRC_BASE.  Depending on which CONFIG_ARCH_OMAP* Kconfig
> > parameter is specified, we then set an SDRC_BASE define to point to
> > one of the two architecture-specific values.
> >
> >   
> IMHO, using of SDRC_BASE as well as CTRL_BASE, PRCM_BASE etc.,
> can lead to name collision, the names is not so unique as may
> seem. I suggest using of OMAP_ prefix for these names.

Good point. We could use OMAP_ prefix and in case of conflicts
with omap1 defines, we could rename them to have OMAP1_ prefix.

Regards,

Tony

  reply	other threads:[~2007-05-17 17:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-16 22:58 [PATCH 0/5] Clean up omap24xx.h symbolic constants Paul Walmsley
2007-05-16 22:58 ` [PATCH 1/5] omap2: modify omap24xx.h to improve constant names and prepare for multi-arch kernels Paul Walmsley
2007-05-16 22:58 ` [PATCH 2/5] omap2: use OMAP24XX_32KSYNCT_BASE in place of OMAP_32KSYNCT_BASE Paul Walmsley
2007-05-16 22:58 ` [PATCH 3/5] omap2: use PRCM_BASE in place of OMAP24XX_PRCM_BASE Paul Walmsley
2007-05-16 22:58 ` [PATCH 4/5] omap2: use SDRC_BASE in place of OMAP24XX_SDRC_BASE Paul Walmsley
2007-05-16 22:58 ` [PATCH 5/5] omap2: use CTRL_BASE in place of OMAP24XX_CTRL_BASE Paul Walmsley
2007-05-17  8:28 ` [PATCH 0/5] Clean up omap24xx.h symbolic constants Dmitry Krivoschekov
2007-05-17 17:43   ` Tony Lindgren [this message]
2007-05-17 17:53     ` Syed Mohammed, Khasim
2007-05-17 18:14       ` Tony Lindgren
2007-05-17 19:11         ` Syed Mohammed, Khasim
2007-05-21 16:52           ` Paul Walmsley
  -- strict thread matches above, loose matches on Subject: below --
2007-05-21 22:59 Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070517174328.GB8556@atomide.com \
    --to=tony@atomide.com \
    --cc=dmitry.krivoschekov@gmail.com \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.