From: Al Viro <viro@ftp.linux.org.uk>
To: David Miller <davem@davemloft.net>
Cc: dedekind@infradead.org, hch@lst.de, akpm@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ubi: kill homegrown endian macros
Date: Thu, 17 May 2007 22:03:19 +0100 [thread overview]
Message-ID: <20070517210319.GT4095@ftp.linux.org.uk> (raw)
In-Reply-To: <20070517.135624.131107441.davem@davemloft.net>
On Thu, May 17, 2007 at 01:56:24PM -0700, David Miller wrote:
> From: Artem Bityutskiy <dedekind@infradead.org>
> Date: Thu, 17 May 2007 17:50:43 +0300
>
> > Well, I see the good side of your change - no home-brewed media<->cpu
> > things. Fair enough and nice. But why don't you make __be32 a struct
> > (just like I do) so that compiler could complain then?
>
> structs get passed on the stack instead of via registers, regardless
> of size, when passed as arguments on some architectures, so there is a
> terrible performance cost of doing things that way
BTW, the lack of home-grown coversions is not a benefit - it's _nice_ to
have protections against mixing be32 and ubi32, etc. Avoiding the mess
with struct, OTOH, *is* a benefit.
So I'd rather go with independent bitwise types and conversions done by
use of be... ones + force-cast. The rest of ubi code remain unchanged.
next prev parent reply other threads:[~2007-05-17 21:03 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-17 14:32 [PATCH] ubi: kill homegrown endian macros Christoph Hellwig
2007-05-17 14:50 ` Artem Bityutskiy
2007-05-17 14:56 ` Christoph Hellwig
2007-05-17 15:09 ` Artem Bityutskiy
2007-05-17 17:29 ` Andrew Morton
2007-05-17 17:46 ` Artem Bityutskiy
2007-05-17 18:18 ` Andrew Morton
2007-05-17 20:32 ` Artem Bityutskiy
2007-05-17 20:30 ` Matthieu CASTET
2007-05-18 2:39 ` David Woodhouse
2007-05-18 2:57 ` John Anthony Kazos Jr.
2007-05-18 3:17 ` David Woodhouse
2007-05-18 11:52 ` John Anthony Kazos Jr.
2007-05-18 14:52 ` David Woodhouse
2007-05-18 22:00 ` Segher Boessenkool
2007-05-19 2:07 ` David Woodhouse
2007-05-19 12:24 ` Segher Boessenkool
2007-05-20 11:29 ` David Woodhouse
2007-05-18 19:55 ` matthieu castet
2007-05-19 1:29 ` David Woodhouse
2007-05-18 20:30 ` matthieu castet
2007-05-17 20:42 ` Al Viro
2007-05-17 20:53 ` Al Viro
2007-05-18 6:58 ` Artem Bityutskiy
2007-05-18 8:38 ` Al Viro
2007-05-17 21:14 ` Dmitry Torokhov
2007-05-17 21:29 ` Al Viro
2007-05-17 21:33 ` David Miller
2007-05-17 21:47 ` Al Viro
2007-05-17 21:26 ` Al Viro
2007-05-17 20:56 ` David Miller
2007-05-17 21:03 ` Al Viro [this message]
2007-05-17 15:50 ` David Woodhouse
2007-05-17 18:12 ` Christoph Hellwig
2007-05-17 18:23 ` Sam Ravnborg
2007-05-17 18:36 ` Christoph Hellwig
2007-05-17 20:18 ` Jeremy Fitzhardinge
2007-05-17 20:27 ` Matthieu CASTET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070517210319.GT4095@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=dedekind@infradead.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.