From: David Miller <davem@davemloft.net>
To: sam@ravnborg.org
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH 05/14] all-archs: consolidate .data section definition in asm-generic
Date: Fri, 18 May 2007 03:21:26 -0700 (PDT) [thread overview]
Message-ID: <20070518.032126.93383845.davem@davemloft.net> (raw)
In-Reply-To: <20070518094231.GA13390@uranus.ravnborg.org>
From: Sam Ravnborg <sam@ravnborg.org>
Date: Fri, 18 May 2007 11:42:31 +0200
> On Fri, May 18, 2007 at 12:16:04AM -0700, David Miller wrote:
> >
> > Looking at these patches reminds me of a quirk in the generic
> > RODATA definition:
> >
> > > #define RODATA \
> > > . = ALIGN(4096); \
> > > .rodata : AT(ADDR(.rodata) - LOAD_OFFSET) { \
> >
> > It uses ALIGN(4096) which is likely supposed to be something
> > like ALIGN(PAGE_SIZE). Perhaps we should handle this by
> > definiting a LD_PAGE_SIZE at the top of vmlinux.ld.S files
> > that need a value other than 4096, and define the default of
> > 4096 in asm-generic/vmlinux.lds.h?
>
> I would much rather use PAGE_SIZE direct since we have access to that symbol.
I completely agree, that seems to be what platforms which have
a configurable page size such as powerpc, ia64, etc. are already
using in their vmlinux.lds.S files, and I'll likely follow suit on
sparc64. :-)
> > If you could take care of this I'd really appreciate it.
> Will do.
> And may expend the effort a bit further when attacking the .lds files.
>
> It will be a week or two before I get at it.
Thanks a lot.
next prev parent reply other threads:[~2007-05-18 10:21 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-18 6:41 kbuild fixes for -rc1 (touches all arch .lds files) Sam Ravnborg
2007-05-18 6:49 ` [PATCH 01/14] kbuild: make modpost section warnings clearer Sam Ravnborg
2007-05-18 6:49 ` Sam Ravnborg
2007-05-18 6:50 ` David Miller
2007-05-18 6:52 ` Jan Engelhardt
2007-05-18 7:12 ` Sam Ravnborg
2007-05-18 7:12 ` Sam Ravnborg
2007-05-18 6:50 ` [PATCH 02/14] kbuild: make better section mismatch reports on i386, arm and mips Sam Ravnborg
2007-05-18 6:50 ` Sam Ravnborg
2007-05-18 6:51 ` [PATCH 03/14] kbuild: add "Section mismatch" warning whitelist for powerpc Sam Ravnborg
2007-05-18 6:51 ` Sam Ravnborg
2007-05-18 6:51 ` [PATCH 04/14] all-archs: consolidate .text section definition in asm-generic Sam Ravnborg
2007-05-18 6:51 ` Sam Ravnborg
2007-05-18 6:52 ` [PATCH 05/14] all-archs: consolidate .data " Sam Ravnborg
2007-05-18 6:52 ` Sam Ravnborg
2007-05-18 7:16 ` David Miller
2007-05-18 9:42 ` Sam Ravnborg
2007-05-18 10:21 ` David Miller [this message]
2007-05-18 10:42 ` Sam Ravnborg
2007-05-18 6:53 ` [PATCH 06/14] kbuild: introduce __init_refok/__initdata_refok to supress section mismatch warnings Sam Ravnborg
2007-05-18 6:53 ` Sam Ravnborg
2007-05-18 9:03 ` Andreas Schwab
2007-05-18 9:21 ` Sam Ravnborg
2007-05-18 6:54 ` [PATCH 07/14] init/main: use __init_refok to fix section mismatch Sam Ravnborg
2007-05-18 6:54 ` Sam Ravnborg
2007-05-18 6:55 ` [PATCH 08/14] mm: fix section mismatch warnings Sam Ravnborg
2007-05-18 6:55 ` Sam Ravnborg
2007-05-18 6:56 ` [PATCH 09/14] mm/slab: fix section mismatch warning Sam Ravnborg
2007-05-18 6:56 ` Sam Ravnborg
2007-05-18 6:57 ` [PATCH 10/14] powerpc: Fix the MODALIAS generation in modpost for of devices Sam Ravnborg
2007-05-18 6:57 ` Sam Ravnborg
2007-05-18 6:59 ` [PATCH 11/14] kbuild: add support for reading stdin with gen_init_cpio Sam Ravnborg
2007-05-18 6:59 ` Sam Ravnborg
2007-05-18 7:00 ` [PATCH 12/14] kbuild: add support for squashing uid/gid in gen_initramfs_list.sh Sam Ravnborg
2007-05-18 7:00 ` Sam Ravnborg
2007-05-18 7:01 ` [PATCH 13/14] kbuild: include limits.h in sumversion.c for PATH_MAX Sam Ravnborg
2007-05-18 7:01 ` Sam Ravnborg
2007-05-18 7:01 ` [PATCH 14/14] kconfig: search harder for curses library in check-lxdialog.sh Sam Ravnborg
2007-05-18 7:01 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070518.032126.93383845.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.