From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1HowMs-0006pd-Jt for mharc-grub-devel@gnu.org; Fri, 18 May 2007 02:55:14 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HowMq-0006ow-VB for grub-devel@gnu.org; Fri, 18 May 2007 02:55:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HowMp-0006oX-Fi for grub-devel@gnu.org; Fri, 18 May 2007 02:55:12 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HowMp-0006oR-A3 for grub-devel@gnu.org; Fri, 18 May 2007 02:55:11 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HowEc-0003wn-PZ for grub-devel@gnu.org; Fri, 18 May 2007 02:46:43 -0400 Received: from [192.168.10.6] (helo=aragorn) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1HowEZ-0007j3-4a for grub-devel@gnu.org; Fri, 18 May 2007 08:46:39 +0200 Received: from rmh by aragorn with local (Exim 4.63) (envelope-from ) id 1HowGT-0000c9-3Y for grub-devel@gnu.org; Fri, 18 May 2007 08:48:37 +0200 Date: Fri, 18 May 2007 08:48:37 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20070518064837.GC1783@aragorn> References: <87d50z2l8z.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87d50z2l8z.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: Genre and OS details not recognized. Subject: Re: Host filesystem access X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 May 2007 06:55:13 -0000 On Thu, May 17, 2007 at 11:28:12PM +0200, Marco Gerards wrote: > + grub_error (GRUB_ERR_BAD_FS, "not a affs filesystem"); > + grub_error (GRUB_ERR_BAD_FS, "not a hfsplus filesystem"); > + grub_error (GRUB_ERR_BAD_FS, "not a sfs filesystem"); I think these should be "an" (but not sure about all them, any native English speaker around?). > diff -u -p -u -p -r1.34 grub-emu.c > --- util/grub-emu.c 16 May 2007 21:38:44 -0000 1.34 > +++ util/grub-emu.c 17 May 2007 21:17:02 -0000 > @@ -185,6 +185,8 @@ main (int argc, char *argv[]) > /* XXX: This is a bit unportable. */ > grub_util_biosdisk_init (args.dev_map); > > + grub_hostfs_init (); > + > grub_init_all (); I find it counter-intuitive that grub_init_all doesn't imply grub_hostfs_init; if there's a design reason for this, maybe the function should be renamed ? (how about grub_filesystems_init + grub_partmaps_init ?) -- Robert Millan My spam trap is honeypot@aybabtu.com. Note: this address is only intended for spam harvesters. Writing to it will get you added to my black list.