From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1HowPs-00083a-EE for mharc-grub-devel@gnu.org; Fri, 18 May 2007 02:58:20 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HowPr-00083P-3v for grub-devel@gnu.org; Fri, 18 May 2007 02:58:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HowPp-000837-LG for grub-devel@gnu.org; Fri, 18 May 2007 02:58:18 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HowPp-00082x-FJ for grub-devel@gnu.org; Fri, 18 May 2007 02:58:17 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HowHc-0004Ie-NO for grub-devel@gnu.org; Fri, 18 May 2007 02:49:49 -0400 Received: from [192.168.10.6] (helo=aragorn) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1HowHV-0007jE-7J; Fri, 18 May 2007 08:49:42 +0200 Received: from rmh by aragorn with local (Exim 4.63) (envelope-from ) id 1HowJN-0000et-QF; Fri, 18 May 2007 08:51:37 +0200 Date: Fri, 18 May 2007 08:51:37 +0200 From: Robert Millan To: Sam Morris Message-ID: <20070518065137.GA2485@aragorn> References: <1178710623.4102.37.camel@xerces> <20070509135853.GA31878@aragorn> <1178719368.4102.48.camel@xerces> <20070509151643.GB16077@aragorn> <1178725065.4102.65.camel@xerces> <20070509161344.GA25183@aragorn> <1179004601.3922.4.camel@xerces> <1179054146.4014.9.camel@xerces> <20070513164407.GA11143@aragorn> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="RnlQjJ0d97Da+TV1" Content-Disposition: inline In-Reply-To: <20070513164407.GA11143@aragorn> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: Genre and OS details not recognized. Cc: grub-devel@gnu.org, 422851@bugs.debian.org, Thomas Stewart Subject: Re: "grub-probe -t partmap" doesn't work with software RAID X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 May 2007 06:58:19 -0000 --RnlQjJ0d97Da+TV1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, May 13, 2007 at 06:44:07PM +0200, Robert Millan wrote: > On Sun, May 13, 2007 at 12:02:26PM +0100, Sam Morris wrote: > > On Sat, 2007-05-12 at 22:16 +0100, Sam Morris wrote: > > > On Wed, 2007-05-09 at 18:13 +0200, Robert Millan wrote: > > > > I'm forwarding you a bug report from Debian. It seems that the grub-probe > > > > -t partmap feature I just added doesn't play nice with RAID. Unfortunately, > > > > I have no idea how software RAID is implemented. Is it okay to just exit > > > > succesfuly and install core.img without any partmap module? > > ... so apparently it isn't. We still need to detect this somehow, or maybe we > could just print "pc gpt".. anyone can cast some light on this? How about this as temporary solution? It's ugly, but it's not worse than what we had before. -- Robert Millan My spam trap is honeypot@aybabtu.com. Note: this address is only intended for spam harvesters. Writing to it will get you added to my black list. --RnlQjJ0d97Da+TV1 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="raid_partmap.diff" Index: util/i386/efi/grub-install.in =================================================================== RCS file: /sources/grub/grub2/util/i386/efi/grub-install.in,v retrieving revision 1.1 diff -u -r1.1 grub-install.in --- util/i386/efi/grub-install.in 16 May 2007 15:05:02 -0000 1.1 +++ util/i386/efi/grub-install.in 18 May 2007 06:48:02 -0000 @@ -187,7 +187,7 @@ fi # Then the partition map module. -partmap_module=`$grub_probe --target=partmap --device-map=${device_map} ${grubdir}` +partmap_module=`$grub_probe --target=partmap --device-map=${device_map} ${grubdir} || echo pc gpt` if test "x$partmap_module" = x -a "x$modules" = x; then echo "Auto-detection of a partition map module failed." 1>&2 echo "Please specify the module with the option \`--modules' explicitly." 1>&2 Index: util/i386/pc/grub-install.in =================================================================== RCS file: /sources/grub/grub2/util/i386/pc/grub-install.in,v retrieving revision 1.13 diff -u -r1.13 grub-install.in --- util/i386/pc/grub-install.in 7 May 2007 19:54:46 -0000 1.13 +++ util/i386/pc/grub-install.in 18 May 2007 06:48:02 -0000 @@ -217,7 +217,7 @@ fi # Then the partition map module. -partmap_module=`$grub_probe --target=partmap --device-map=${device_map} ${grubdir}` +partmap_module=`$grub_probe --target=partmap --device-map=${device_map} ${grubdir} || echo pc gpt` if test "x$partmap_module" = x -a "x$modules" = x; then echo "Auto-detection of a partition map module failed." 1>&2 echo "Please specify the module with the option \`--modules' explicitly." 1>&2 --RnlQjJ0d97Da+TV1--