From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756166AbXERMCS (ORCPT ); Fri, 18 May 2007 08:02:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754426AbXERMCK (ORCPT ); Fri, 18 May 2007 08:02:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:60402 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754361AbXERMCJ (ORCPT ); Fri, 18 May 2007 08:02:09 -0400 From: Andi Kleen To: "Siddha, Suresh B" Subject: Re: [patch] x86_64, irq: check remote IRR bit before migrating level triggered irq Date: Fri, 18 May 2007 14:00:12 +0200 User-Agent: KMail/1.9.1 Cc: mingo@elte.hu, ebiederm@xmission.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, nanhai.zou@intel.com, asit.k.mallick@intel.com, keith.packard@intel.com References: <20070517230324.GB8089@linux-os.sc.intel.com> In-Reply-To: <20070517230324.GB8089@linux-os.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200705181400.12811.ak@suse.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Friday 18 May 2007 01:03, Siddha, Suresh B wrote: > Normally, the EOI generated by local APIC for level trigger interrupt > contains vector number. The IOAPIC will take this vector number and > search the IOAPIC RTE entries for an entry with matching vector number and > clear the remote IRR bit (indicate EOI). However, if the vector number is > changed (as in step 3) the IOAPIC will not find the RTE entry when the EOI > is received later. This will cause the remote IRR to get stuck causing the > interrupt hang (no more interrupt from this RTE). Does this happen often or did you only see it in some extreme or obscure case? > + /* > + * If the EOI still didn't reach the RTE corresponding to the > + * level triggered irq, postpone the irq migration to the next > + * irq arrival event. > + */ > + if (pending_eoi(irq)) { > + irq_desc[irq].status |= IRQ_MOVE_PENDING; > + return; Other code seems to have similar problems, but we don't have any lock protecting that bitmap against parallel updates outside the irq itself, don't we? Perhaps it needs to be all set_bit() -Andi