From: "John W. Linville" <linville@tuxdriver.com>
To: Eugene Teo <eteo@redhat.com>
Cc: linux-kernel@vger.kernel.org, jeff@garzik.org,
linux-wireless@vger.kernel.org, Florin Malita <fmalita@gmail.com>
Subject: Re: [2.6 patch] drivers/net/wireless/libertas/rx.c: fix use-after-free
Date: Fri, 18 May 2007 13:46:23 -0400 [thread overview]
Message-ID: <20070518174623.GA3492@tuxdriver.com> (raw)
In-Reply-To: <464DD957.9040803@redhat.com>
First, please send all wireless patches to
linux-wireless@vger.kernel.org, and be sure to CC me as well...thanks!
On Sat, May 19, 2007 at 12:50:31AM +0800, Eugene Teo wrote:
> libertas_upload_rx_packet() calls netif_rx() before returning, and it always return 0.
> Also within libertas_upload_rx_packet(), it will initialize skb->protocol anyways.
>
> Spotted by the Coverity checker.
A nearly identical patch was posted by Florin Malita <fmalita@gmail.com>
to netdev (also the wrong list) on Wednesday evening.
> done:
> LEAVE();
>
> - skb->protocol = __constant_htons(0x0019); /* ETH_P_80211_RAW */
> -
Except for this part...is this intentional?
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2007-05-18 18:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-18 16:50 [2.6 patch] drivers/net/wireless/libertas/rx.c: fix use-after-free Eugene Teo
2007-05-18 17:46 ` John W. Linville [this message]
2007-05-19 3:14 ` Eugene Teo
2007-05-21 13:31 ` John W. Linville
2007-05-21 14:30 ` Eugene Teo
2007-05-21 14:30 ` Eugene Teo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070518174623.GA3492@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=eteo@redhat.com \
--cc=fmalita@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.