All of lore.kernel.org
 help / color / mirror / Atom feed
From: "S.Çağlar Onur" <caglar@pardus.org.tr>
To: xen-devel@lists.xensource.com
Cc: Ulrich Drepper <drepper@redhat.com>
Subject: Re: [PATCH] Enabling vtpm causes installation error
Date: Sat, 19 May 2007 03:01:36 +0300	[thread overview]
Message-ID: <200705190301.37102.caglar@pardus.org.tr> (raw)
In-Reply-To: <464E3CA1.6050102@redhat.com>


[-- Attachment #1.1: Type: text/plain, Size: 1174 bytes --]

19 May 2007 Cts tarihinde, Ulrich Drepper şunları yazmıştı: 
> S.Çağlar Onur wrote:
> > -+  struct sockaddr_un client_addr;
> > ++  struct sockaddr client_addr;
>
> This is very wrong.  struct sockaddr is basically an abstract type.  You
> never allocate objects of this type.  Add casts in places where
> client_addr is used.

Irgh, thanks! Here is the updated one;

Signed-off-by: S.Çağlar Onur <caglar@pardus.org.tr>

diff -r aee991c7723a tools/vtpm/vtpm.patch
--- a/tools/vtpm/vtpm.patch	Wed May 09 16:34:47 2007 +0100
+++ b/tools/vtpm/vtpm.patch	Sat May 19 03:00:28 2007 +0300
@@ -579,7 +579,7 @@ diff -uprN tpm_emulator/tpmd.c vtpm/tpmd
 +        memset(&client_addr, 0, sizeof(client_addr));
 +        client_length = sizeof(client_addr);
 +
-+        vtpm_rx_fh = vtpm_tx_fh = accept(sockfd, &client_addr, 
&client_length);
++        vtpm_rx_fh = vtpm_tx_fh = accept(sockfd, (struct sockaddr 
*)&client_addr, &client_length);
 +      }
 +#endif
      }

Cheers
-- 
S.Çağlar Onur <caglar@pardus.org.tr>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

      reply	other threads:[~2007-05-19  0:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-18 23:38 [PATCH] Enabling vtpm causes installation error S.Çağlar Onur
2007-05-18 23:54 ` Ulrich Drepper
2007-05-19  0:01   ` S.Çağlar Onur [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200705190301.37102.caglar@pardus.org.tr \
    --to=caglar@pardus.org.tr \
    --cc=drepper@redhat.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.