From: Eric Wong <normalperson@yhbt.net>
To: git@vger.kernel.org
Cc: Matthieu Moy <Matthieu.Moy@imag.fr>
Subject: Re: [BUG] git-svn dcommit fails (connection closed unexpectedly)
Date: Fri, 18 May 2007 23:14:23 -0700 [thread overview]
Message-ID: <20070519061422.GA17528@muzzle> (raw)
In-Reply-To: <vpqtzuf46k9.fsf@bauges.imag.fr>
Matthieu Moy <Matthieu.Moy@imag.fr> wrote:
> "Lars Hjemli" <lh@elementstorage.no> writes:
>
> > Is this happening if you dcommit a file in a new directory?
>
> That's it indeed.
>
> The attached script seems to reproducibly trigger the problem on my
> box:
>
> $ ../git-svn-test.sh
> Checked out revision 0.
> A file
> Adding file
> Transmitting file data .
> Committed revision 1.
> Initialized empty Git repository in .git/
> moy@localhost's password:
> A file
> r1 = 4357177f2d927931d31c8c49c0237561648001a7 (git-svn)
>
> Checked out HEAD:
> svn+ssh://localhost//home/moy/tmp/test/test.26377/svnrepo r1
> Created commit aa2db5a: newdir
> 1 files changed, 1 insertions(+), 0 deletions(-)
> create mode 100644 newdir/newfile
> moy@localhost's password:
> A newdir/newfile
> Network connection closed unexpectedly: Connection closed unexpectedly at /home/moy/bin/local/verimag/git-svn line 405
> $
Thanks to your script I can reproduce it.
svnserve (not git-svn) is segfaulting on me...
> #! /bin/sh
>
> mkdir test.$$
> cd test.$$
>
> svnadmin create svnrepo
>
> svn co file://$PWD/svnrepo svnco
>
> cd svnco
> echo content > file
> svn add file
> svn commit -m "added file"
> cd ../
>
> # This triggers the bug.
> git-svn clone svn+ssh://localhost/$PWD/svnrepo git-svn-co
>
> # while this doesn't
> # git-svn clone file://localhost/$PWD/svnrepo git-svn-co
>
> cd git-svn-co
>
> mkdir newdir
> echo othercontent > newdir/newfile
>
> git add newdir/newfile
>
> git commit -m "newdir"
>
> git-svn dcommit
Thanks. I didn't realize entirely new directories (and not empty
directories in svn but git thought were new) were what was causing
things to break.
--
Eric Wong
next prev parent reply other threads:[~2007-05-19 6:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 9:09 [BUG] git-svn dcommit fails (connection closed unexpectedly) Matthieu Moy
2007-05-11 11:27 ` Lars Hjemli
2007-05-11 11:30 ` Lars Hjemli
2007-05-11 12:51 ` Matthieu Moy
2007-05-14 18:13 ` Matthieu Moy
2007-05-19 6:14 ` Eric Wong [this message]
2007-05-19 9:58 ` [PATCH] git-svn: avoid crashing svnserve when creating new directories Eric Wong
2007-05-19 10:19 ` Matthieu Moy
2007-05-19 10:58 ` Eric Wong
2007-05-19 12:02 ` Matthieu Moy
2007-05-13 17:17 ` [BUG] git-svn dcommit fails (connection closed unexpectedly) Eric Wong
2007-05-13 17:49 ` Martin Eisenhardt
2007-05-13 18:24 ` Karl Hasselström
2007-05-13 21:01 ` Eric Wong
2007-05-14 0:39 ` Eric Wong
2007-05-14 17:26 ` Linus Torvalds
2007-05-14 17:50 ` Matthieu Moy
2007-05-14 12:27 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070519061422.GA17528@muzzle \
--to=normalperson@yhbt.net \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.