From: Martin Waitz <tali@admingilde.org>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH] allow commands to be executed in submodules
Date: Sun, 20 May 2007 23:08:27 +0200 [thread overview]
Message-ID: <20070520210827.GI5412@admingilde.org> (raw)
In-Reply-To: <20070520205933.GD25462@steel.home>
[-- Attachment #1: Type: text/plain, Size: 935 bytes --]
hoi :)
On Sun, May 20, 2007 at 10:59:33PM +0200, Alex Riesen wrote:
> Is there multiple places? Is it hard to create a specific function out
> of a generic one? (which can be used from other places and your
> specific can't and we would need the generic one anyway).
you can add a specific new function for submodules, dropping the
nice property of child_process that you only have to initialize a few
fields and then can run the command.
> "Generic" is not about "multiple places". Generic is about "general"
> as opposite to "specific". Gives you flexibility and wider application
> range.
Generic code and abstractions only make sense when they are _useful_.
Lets not overengineer it. If we later see that we need more, then
so be it. KISS.
But now lets go on and don't discuss about such details.
I'm happy if I can run commands in submodules and don't care about the
actual code.
--
Martin Waitz
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-05-20 21:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-20 15:39 [PATCH] allow commands to be executed in submodules Martin Waitz
2007-05-20 18:14 ` Alex Riesen
2007-05-20 18:25 ` Junio C Hamano
2007-05-20 20:48 ` Martin Waitz
2007-05-20 20:59 ` Alex Riesen
2007-05-20 21:08 ` Martin Waitz [this message]
[not found] ` <20070521090339.GH942MdfPADPa@greensroom.kotnet.org>
2007-05-21 22:48 ` [PATCH] Add ability to specify environment extension to run_command Alex Riesen
2007-05-21 23:02 ` Junio C Hamano
2007-05-22 6:03 ` Martin Waitz
2007-05-22 6:33 ` Junio C Hamano
2007-05-22 6:38 ` Shawn O. Pearce
2007-05-22 6:54 ` Sven Verdoolaege
2007-05-22 21:51 ` Alex Riesen
2007-05-22 21:47 ` Alex Riesen
2007-05-22 21:48 ` [PATCH] Add run_command_v_opt_cd: chdir into a directory before exec Alex Riesen
2007-05-22 21:48 ` [PATCH] Add ability to specify environment extension to run_command Alex Riesen
2007-05-22 21:49 ` [PATCH] Allow environment variables to be unset in the processes started by run_command Alex Riesen
2007-05-22 22:19 ` [PATCH] Add ability to specify environment extension to run_command Junio C Hamano
2007-05-22 23:14 ` Alex Riesen
2007-05-23 20:21 ` [PATCH] Allow environment variables to be unset in the processes started by run_command Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070520210827.GI5412@admingilde.org \
--to=tali@admingilde.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.