Re: [PATCH 1/2] sysfs: fix condition check in sysfs_drop_dentry()

[Maneesh Soni <maneesh@in.ibm.com>]

On Thu, May 17, 2007 at 07:52:53PM +0200, Tejun Heo wrote:
> The condition check doesn't make much sense as it basically always
> succeeds.  This causes NULL dereferencing on certain cases.  It seems
> that parentheses are put in the wrong place.  Fix it.
> 
> DON'T APPLY JUST YET
> ---
> 
> Maneesh, is this correct?
> 
Yes.

>  fs/sysfs/inode.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: work/fs/sysfs/inode.c
> ===================================================================
> --- work.orig/fs/sysfs/inode.c
> +++ work/fs/sysfs/inode.c
> @@ -250,7 +250,7 @@ void sysfs_drop_dentry(struct sysfs_dire
>  	if (dentry) {
>  		spin_lock(&dcache_lock);
>  		spin_lock(&dentry->d_lock);
> -		if (!(d_unhashed(dentry) && dentry->d_inode)) {
> +		if (!d_unhashed(dentry) && dentry->d_inode) {
>  			inode = dentry->d_inode;
>  			spin_lock(&inode->i_lock);
>  			__iget(inode);


Ack'ed

Thanks
Maneesh

-- 
Maneesh Soni
Linux Technology Center,
IBM India Systems and Technology Lab, 
Bangalore, India