Re: [RFC,PATCH 5/14] knfsd: max_payload per transport

[Greg Banks <gnb@sgi.com>]

On Thu, May 17, 2007 at 10:23:06AM -0500, Tom Tucker wrote:
> On Thu, 2007-05-17 at 20:34 +1000, Neil Brown wrote:
> > On Thursday May 17, gnb@sgi.com wrote:
> > > 
> > > Make svc_max_payload() delegate to a new method in svc_sock_ops
> > > instead of reaching into the socket (beause later the NFS/RDMA
> > > transport will not even have a socket).
> > > 
> > > Signed-off-by: Greg Banks <gnb@melbourne.sgi.com>
> > > Signed-off-by: Peter Leckie <pleckie@melbourne.sgi.com>
> > ..
> > >  
> > > +static u32 svc_tcp_max_payload(struct svc_sock *svsk)
> > > +{
> > > +	return RPCSVC_MAXPAYLOAD_TCP;
> > > +}
> > > +
> > 
> > Seeing these are implementation (or protocol) defined constants, do we
> > really need a function call?  How about a
> > 	int max_payload;
> > in struct svc_sock_ops??  Or is it tacky to put an integer in a *_ops
> > structure? 
> 
> I think if we called it a "svc_transport" structure instead of a
> "svc_sock_ops" structure, it removes the tackiness. It's also more
> accurate since "svc_sock_ops" implies these are socket ops which they
> are not.

I like this idea, so I renamed

svc_sock_ops -> svc_transport_type
sko_foo -> st_foo
sk_ops -> sk_type

Greg.
-- 
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
Apparently, I'm Bedevere.  Which MPHG character are you?
I don't speak for SGI.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs