From: Andrew Morton <akpm@linux-foundation.org>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: linux-scsi@vger.kernel.org, bunk@stusta.de
Subject: Re: [patch 18/28] scsi/lpfc/lpfc_init.c: remove unused variable
Date: Tue, 22 May 2007 12:34:00 -0700 [thread overview]
Message-ID: <20070522123400.8acc4e1f.akpm@linux-foundation.org> (raw)
In-Reply-To: <1179860642.3738.45.camel@mulgrave.il.steeleye.com>
On Tue, 22 May 2007 14:04:02 -0500
James Bottomley <James.Bottomley@SteelEye.com> wrote:
> On Thu, 2007-05-10 at 23:01 -0700, akpm@linux-foundation.org wrote:
> > From: Adrian Bunk <bunk@stusta.de>
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>
> Actually, not against vanilla linus:
>
> drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_pci_probe_one':
> drivers/scsi/lpfc/lpfc_init.c:1581: error: 'retval' undeclared (first use in this function)
> drivers/scsi/lpfc/lpfc_init.c:1581: error: (Each undeclared identifier is reported only once
> drivers/scsi/lpfc/lpfc_init.c:1581: error: for each function it appears in.)
>
> There's probably some global change in -mm that makes pci_set_mwi()
> return void ... in which case, this needs to be swept up into it.
>
yep, sorry. I rebadged this patch as being
"after Greg merges add-pci_try_set_mwi.patch"
prev parent reply other threads:[~2007-05-22 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 6:01 [patch 18/28] scsi/lpfc/lpfc_init.c: remove unused variable akpm
2007-05-11 12:40 ` James Smart
2007-05-22 19:04 ` James Bottomley
2007-05-22 19:34 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070522123400.8acc4e1f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@SteelEye.com \
--cc=bunk@stusta.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.