From: Cyrill Gorcunov <gorcunov@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] UDF: possible usage of uninitialized variables
Date: Tue, 22 May 2007 21:52:23 +0400 [thread overview]
Message-ID: <20070522175223.GA8259@cvg> (raw)
A few variables could be used without being explicitly initialized.
Fixed.
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
balloc.c | 6 +++++-
super.c | 5 ++++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/balloc.c b/balloc.c
index 4cec910..be37393 100644
--- a/balloc.c
+++ b/balloc.c
@@ -744,7 +744,11 @@ static int udf_table_new_block(struct super_block * sb,
uint32_t spread = 0xFFFFFFFF, nspread = 0xFFFFFFFF;
uint32_t newblock = 0, adsize;
uint32_t elen, goal_elen = 0;
- kernel_lb_addr eloc, goal_eloc;
+ kernel_lb_addr eloc;
+ kernel_lb_addr goal_eloc = {
+ .logicalBlockNum = 0,
+ .partitionReferenceNum = 0,
+ };
struct extent_position epos, goal_epos;
int8_t etype;
diff --git a/super.c b/super.c
index 9b8644a..068a99c 100644
--- a/super.c
+++ b/super.c
@@ -1358,7 +1358,10 @@ udf_load_partition(struct super_block *sb, kernel_lb_addr *fileset)
case UDF_VIRTUAL_MAP15:
case UDF_VIRTUAL_MAP20:
{
- kernel_lb_addr ino;
+ kernel_lb_addr ino = {
+ .logicalBlockNum = 0,
+ .partitionReferenceNum = 0,
+ };
if (!UDF_SB_LASTBLOCK(sb))
{
next reply other threads:[~2007-05-22 17:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-22 17:52 Cyrill Gorcunov [this message]
2007-05-22 18:39 ` [PATCH] UDF: possible usage of uninitialized variables Andrew Morton
2007-05-22 20:29 ` Jan Kara
2007-05-23 14:17 ` Cyrill Gorcunov
2007-05-23 16:05 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070522175223.GA8259@cvg \
--to=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.