All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Anant Nitya <kernel@prachanda.info>,
	linux-kernel@vger.kernel.org
Subject: Re: [BUG] local_softirq_pending storm
Date: Tue, 22 May 2007 22:10:46 +0200	[thread overview]
Message-ID: <20070522201046.GA6113@elte.hu> (raw)
In-Reply-To: <6bffcb0e0705221203s1ba21ed3j641e91036859db7d@mail.gmail.com>


* Michal Piotrowski <michal.k.k.piotrowski@gmail.com> wrote:

> Bad news - I hit a bug in 2.6.22-rc2-hrt3. Bug symptoms:
> - X hangs (keyboard, mouse, sound etc.)
> - only Magic SysRq works

please try the patch below! I think we have nailed this bug.

	Ingo

Index: linux/kernel/sched.c
===================================================================
--- linux.orig/kernel/sched.c
+++ linux/kernel/sched.c
@@ -4212,9 +4212,7 @@ int __sched cond_resched_softirq(void)
 	BUG_ON(!in_softirq());
 
 	if (need_resched() && system_state == SYSTEM_RUNNING) {
-		raw_local_irq_disable();
-		_local_bh_enable();
-		raw_local_irq_enable();
+		local_bh_enable();
 		__cond_resched();
 		local_bh_disable();
 		return 1;

  parent reply	other threads:[~2007-05-22 20:11 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-09 14:12 [BUG] local_softirq_pending storm Anant Nitya
2007-05-09 16:31 ` Thomas Gleixner
2007-05-10 11:53   ` Anant Nitya
2007-05-10 21:58     ` Thomas Gleixner
2007-05-17  6:41       ` Anant Nitya
2007-05-18 13:01         ` Thomas Gleixner
2007-05-19  4:30           ` Anant Nitya
2007-05-19  9:55           ` Anant Nitya
2007-05-19 19:11             ` Thomas Gleixner
2007-05-19 21:23               ` Anant Nitya
2007-05-20 21:43                 ` Thomas Gleixner
2007-05-21  6:22                   ` Anant Nitya
2007-05-21  9:01                     ` Thomas Gleixner
2007-05-21 10:02                       ` Anant Nitya
2007-05-21 18:45                       ` Anant Nitya
2007-05-22 19:03                   ` Michal Piotrowski
2007-05-22 19:59                     ` Michal Piotrowski
2007-05-22 20:10                     ` Ingo Molnar [this message]
2007-05-22 20:23                       ` Michal Piotrowski
2007-05-23 17:00                       ` Chuck Ebbert
2007-05-23 18:38                         ` Chuck Ebbert
2007-05-23 23:24                           ` Anant Nitya
2007-05-23 23:24                           ` Anant Nitya
2007-05-24  7:45                         ` Ingo Molnar
2007-05-20 10:18               ` Heiko Carstens
2007-05-20 13:52                 ` Thomas Gleixner
2007-05-20 18:36                   ` Heiko Carstens
     [not found]                     ` <20070520191800.GA14225@osiris.ibm.com>
     [not found]                       ` <1179689389.6570.1.camel@chaos>
     [not found]                         ` <20070521200428.GA9855@osiris.ibm.com>
2007-05-23 20:54                           ` Mikulas Patocka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070522201046.GA6113@elte.hu \
    --to=mingo@elte.hu \
    --cc=kernel@prachanda.info \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.