All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>,
	Pierre Ossman <drzeus-list@drzeus.cx>,
	LKML <linux-kernel@vger.kernel.org>,
	Kristian H?gsberg <krh@bitplanet.net>
Subject: Re: Race free attributes in sysfs
Date: Tue, 22 May 2007 21:25:29 -0700	[thread overview]
Message-ID: <20070523042529.GC27329@kroah.com> (raw)
In-Reply-To: <20070522103857.17bf1a3e@gondolin.boeblingen.de.ibm.com>

On Tue, May 22, 2007 at 10:38:57AM +0200, Cornelia Huck wrote:
> On Mon, 21 May 2007 21:28:15 +0200,
> Kay Sievers <kay.sievers@vrfy.org> wrote:
> 
> > We could change the driver-core to suppress the creation of an attribute
> > if the attribute's show() or store() method returns something like
> > -ENOENT at registration time?
> > The driver would pass _all_ possible attributes of the device at
> > registration time, but the core would only create the attributes which
> > are implemented for this particular device? Would that work for you?
> > 
> > There are already subsystems who need to do similar things internally
> > (firewire), and it may be nice to add such functionality to the core.
> 
> This sounds a bit hackish (overloading the meaning of the show() and
> store() methods).

Firewire already does this today, it's actually really nice :)

> > You can assign any number of attribute groups to the device. If they
> > don't have a group name, they will all be created directly at the device
> > level. Would that work for you?
> 
> What about generic "conditional attribute groups"? Add a check() method
> which is called just before adding them, and only add them if check()
> returned 0 (or doesn't exist)?

People want this on a per-attribute basis, if you did it on a group
level, we would have a bunch of groups with only one attribute in it,
which would be messy.

thanks,

greg k-h

  reply	other threads:[~2007-05-23  4:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-20 11:01 Race free attributes in sysfs Pierre Ossman
2007-05-21  3:12 ` Dmitry Torokhov
2007-05-21  7:47   ` Pierre Ossman
2007-05-22 21:24   ` Mark Lord
2007-05-23  2:43     ` Dmitry Torokhov
2007-05-23  4:21       ` Greg KH
2007-05-23 13:27         ` Mark Lord
2007-05-23 15:14           ` Greg KH
2007-05-26 16:12             ` Bill Davidsen
2007-05-27  8:57               ` Greg KH
2007-05-21 17:50 ` Kay Sievers
2007-05-21 18:43   ` Pierre Ossman
2007-05-21 19:28     ` Kay Sievers
2007-05-22  8:38       ` Cornelia Huck
2007-05-23  4:25         ` Greg KH [this message]
2007-05-22 15:40       ` Pierre Ossman
2007-05-22 15:58         ` Kristian Høgsberg
2007-05-22 21:25         ` Mark Lord
2007-05-23  4:24         ` Greg KH
2007-05-23  5:44           ` Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070523042529.GC27329@kroah.com \
    --to=greg@kroah.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=drzeus-list@drzeus.cx \
    --cc=kay.sievers@vrfy.org \
    --cc=krh@bitplanet.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.