From: Andrew Morton <akpm@linux-foundation.org>
To: "Renato Golin" <rengolin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov <dtor@mail.ru>
Subject: Re: [PATCH] joydev.c automatic re-calibration
Date: Wed, 23 May 2007 11:00:13 -0700 [thread overview]
Message-ID: <20070523110013.5ffc4a91.akpm@linux-foundation.org> (raw)
In-Reply-To: <d9b9d95f0705221733l46de4262qd9c3f5047c53667@mail.gmail.com>
On Wed, 23 May 2007 01:33:14 +0100 "Renato Golin" <rengolin@gmail.com> wrote:
> This small patch adds the automatic recalibration feature without
> spoiling previously calibrated devices. It's a fix for those joysticks
> that report faulty range, specially Saitek Cyborg Evo Force.
>
> File: drivers/input/joydev.c
> Fix:
> - extracted code from joydev_connect to method
> joydev_calculate_correction to be able to call it from both
> joydev_event upon recalibration and joydev_connect during first
> connection.
> - on joydev_connect check ranges and zero calibration if found out of range
> - on joydev_event, every time found out of range, update min/max and
> recalculate the correction
A few patch protocol things:
- Please always prepare patches in `patch -p1' form
- Include a Signed-off-by: as per Documentation/SubmittingPatches,
section 11.
- Avoid including two copies of the patch in the one email. Inlined plain
text is preferred, ext/plain attachments are grudgingly accepted.
I descrambled the patch, fixed a reject and queued it up in the -mm tree
for Dmitry's consideration, thanks.
next prev parent reply other threads:[~2007-05-23 18:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-23 0:33 [PATCH] joydev.c automatic re-calibration Renato Golin
2007-05-23 9:38 ` Jiri Kosina
2007-05-23 10:01 ` Renato Golin
2007-05-23 10:09 ` Renato Golin
2007-05-23 14:37 ` Dmitry Torokhov
2007-05-23 14:46 ` Jiri Kosina
2007-05-23 15:25 ` Renato Golin
2007-05-23 18:00 ` Andrew Morton [this message]
2007-05-23 18:20 ` Renato Golin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070523110013.5ffc4a91.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dtor@mail.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=rengolin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.