From: Ingo Oeser <netdev@axxeo.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [NET] napi: Call __netif_rx_complete in netif_rx_complete
Date: Wed, 23 May 2007 19:50:07 +0200 [thread overview]
Message-ID: <200705231950.08210.netdev@axxeo.de> (raw)
In-Reply-To: <20070520103910.GA25808@gondor.apana.org.au>
Hi Herbert,
Herbert Xu schrieb:
> [NET] napi: Call __netif_rx_complete in netif_rx_complete
>
> This patch kills a little bit of code duplication between the two
> variants of netif_rx_complete.
What about making it out of line?
There is nothing the compiler can optimize away here
and the code looks bigger than a function call with a single argument.
Maybe even make the callers out of line?
Best regards
Ingo Oeser
prev parent reply other threads:[~2007-05-23 17:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-20 10:39 [NET] napi: Call __netif_rx_complete in netif_rx_complete Herbert Xu
2007-05-23 17:50 ` Ingo Oeser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705231950.08210.netdev@axxeo.de \
--to=netdev@axxeo.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.