From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [NETFILTER 02/07]: nf_conntrack_ftp: fix newline sequence number calculation Date: Thu, 24 May 2007 16:41:59 -0700 (PDT) Message-ID: <20070524.164159.82356841.davem@davemloft.net> References: <20070524215833.14308.60841.sendpatchset@localhost.localdomain> <20070524215836.14308.55840.sendpatchset@localhost.localdomain> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netfilter-devel@lists.netfilter.org To: kaber@trash.net Return-path: In-Reply-To: <20070524215836.14308.55840.sendpatchset@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org From: Patrick McHardy Date: Fri, 25 May 2007 00:02:09 +0200 (MEST) > [NETFILTER]: nf_conntrack_ftp: fix newline sequence number calculation > > When the packet size is changed by the FTP NAT helper, the connection > tracking helper adjusts the sequence number of the newline character > by the size difference. This is wrong because NAT sequence number > adjustment happens after helpers are called, so the unadjusted number > is compared to the already adjusted one. > > Based on report by YU, Haitao > > Signed-off-by: Patrick McHardy Applied.