From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753501AbXEXUsf (ORCPT ); Thu, 24 May 2007 16:48:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751088AbXEXUs2 (ORCPT ); Thu, 24 May 2007 16:48:28 -0400 Received: from smtp1.linux-foundation.org ([207.189.120.13]:46470 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750841AbXEXUs2 (ORCPT ); Thu, 24 May 2007 16:48:28 -0400 Date: Thu, 24 May 2007 13:48:22 -0700 From: Andrew Morton To: Ben Collins Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] RTC: Ratelimit "lost interrupts" message Message-Id: <20070524134822.ed020127.akpm@linux-foundation.org> In-Reply-To: References: <98cd38b5.git.bcollins@ubuntu.com> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 23 May 2007 18:23:06 -0400 Ben Collins wrote: > Signed-off-by: Ben Collins > --- > drivers/char/rtc.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/char/rtc.c b/drivers/char/rtc.c > index 20380a2..22cf7aa 100644 > --- a/drivers/char/rtc.c > +++ b/drivers/char/rtc.c > @@ -1159,7 +1159,8 @@ static void rtc_dropped_irq(unsigned long data) > > spin_unlock_irq(&rtc_lock); > > - printk(KERN_WARNING "rtc: lost some interrupts at %ldHz.\n", freq); > + if (printk_ratelimit()) > + printk(KERN_WARNING "rtc: lost some interrupts at %ldHz.\n", freq); > Presumably someone is getting a lot of these messages. Do we know why? Is there something which needs fixing here?