From: Andrew Morton <akpm@linux-foundation.org>
To: Jarek Poplawski <jarkao2@o2.pl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] smpboot: cachesize comparison fix in smp_tune_scheduling()
Date: Thu, 24 May 2007 16:02:07 -0700 [thread overview]
Message-ID: <20070524160207.51a478cd.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070524103322.GA1920@ff.dom.local>
On Thu, 24 May 2007 12:33:23 +0200
Jarek Poplawski <jarkao2@o2.pl> wrote:
>
> smpboot: cachesize comparison fix in smp_tune_scheduling()
>
> boot_cpu_data.x86_cache_size is signed int and can be < 0 too.
>
> PS: this function is removed from current -mm.
>
>
> Signed-off-by: Jarek Poplawski <jarkao2@o2.pl>
>
> ---
>
> diff -Nurp 2.6.22-rc2-git5-/arch/i386/kernel/smpboot.c 2.6.22-rc2-git5/arch/i386/kernel/smpboot.c
> --- 2.6.22-rc2-git5-/arch/i386/kernel/smpboot.c 2007-05-24 09:37:11.000000000 +0200
> +++ 2.6.22-rc2-git5/arch/i386/kernel/smpboot.c 2007-05-24 11:48:03.000000000 +0200
> @@ -948,7 +948,7 @@ static void smp_tune_scheduling(void)
> if (cpu_khz) {
> cachesize = boot_cpu_data.x86_cache_size;
>
> - if (cachesize > 0)
> + if ((long)cachesize > 0)
> max_cache_size = cachesize * 1024;
> }
> }
Under what conditions can boot_cpu_data.x86_cache_size be negative?
Have negative values of boot_cpu_data.x86_cache_size been observed in
practice?
Thanks.
next prev parent reply other threads:[~2007-05-24 23:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-24 10:33 [PATCH] smpboot: cachesize comparison fix in smp_tune_scheduling() Jarek Poplawski
2007-05-24 23:02 ` Andrew Morton [this message]
2007-05-25 6:06 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070524160207.51a478cd.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jarkao2@o2.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.