All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Roland Dreier <rdreier@cisco.com>
Cc: Arjan van de Ven <arjan@linux.intel.com>,
	Rob Landley <rob@landley.net>,
	linux-kernel@vger.kernel.org
Subject: Re: Status of CONFIG_FORCED_INLINING?
Date: Thu, 24 May 2007 19:10:19 +0200	[thread overview]
Message-ID: <20070524171019.GA4470@stusta.de> (raw)
In-Reply-To: <ada7iqz9qlj.fsf@cisco.com>

On Wed, May 23, 2007 at 02:28:56PM -0700, Roland Dreier wrote:
>  > - every static function in a header file must be __always_inline
> 
> Why?  Why does it matter whether a function is defined in a .h file or
> a .c file?  Can't the compiler decide better than we can whether
> something should be inlined or not?
> 
> Your argument seems to imply that we should never use the inline
> keyword at all.

A function only belongs into a header file if we always want it inlined, 
otherwise it belongs into a C file.

>  - R.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  parent reply	other threads:[~2007-05-24 17:10 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-23 19:10 Status of CONFIG_FORCED_INLINING? Rob Landley
2007-05-23 19:42 ` Arjan van de Ven
2007-05-23 21:22   ` Adrian Bunk
2007-05-23 21:28     ` Roland Dreier
2007-05-24 12:38       ` Robert P. J. Day
2007-05-24 16:55         ` Rob Landley
2007-05-24 17:10       ` Adrian Bunk [this message]
2007-05-24 17:14         ` Roland Dreier
2007-05-24 17:47           ` Rob Landley
2007-05-24 17:47             ` Arjan van de Ven
2007-05-24 18:14               ` Rob Landley
2007-05-24 17:55             ` Roland Dreier
2007-05-24 18:07               ` Adrian Bunk
2007-05-24 18:32                 ` Roland Dreier
2007-05-24 22:41                   ` Adrian Bunk
2007-05-24 17:57           ` Adrian Bunk
2007-05-23 21:31     ` Arjan van de Ven
2007-05-24 17:12       ` Adrian Bunk
2007-05-24 16:29     ` Jan Engelhardt
2007-05-24 17:14       ` Adrian Bunk
2007-05-24 17:17         ` Arjan van de Ven
2007-05-24 17:40       ` Rob Landley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070524171019.GA4470@stusta.de \
    --to=bunk@stusta.de \
    --cc=arjan@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdreier@cisco.com \
    --cc=rob@landley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.