From: Patrick McHardy <kaber@trash.net>
To: davem@davemloft.net
Cc: netfilter-devel@lists.netfilter.org, Patrick McHardy <kaber@trash.net>
Subject: [NETFILTER 05/07]: nf_conntrack_h323: remove unnecessary process of Information signal
Date: Fri, 25 May 2007 00:02:13 +0200 (MEST) [thread overview]
Message-ID: <20070524215840.14308.13646.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20070524215833.14308.60841.sendpatchset@localhost.localdomain>
[NETFILTER]: nf_conntrack_h323: remove unnecessary process of Information signal
According to the implementation of H.323, it's not necessary to check the
addresses in Information signals.
Signed-off-by: Jing Min Zhao <zhaojingmin@vivecode.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
commit 6fdca918957ecf41e1b5c416df341cfa48080fcd
tree 16a0761c152686fb74b89e81d4d67d6a329ab540
parent e71d7c2a5a69f20bd077b91bcc240f7bada53e48
author Jing Min Zhao <zhaojingmin@vivecode.com> Thu, 24 May 2007 23:49:58 +0200
committer Patrick McHardy <kaber@trash.net> Thu, 24 May 2007 23:49:58 +0200
net/netfilter/nf_conntrack_h323_main.c | 29 -----------------------------
1 files changed, 0 insertions(+), 29 deletions(-)
diff --git a/net/netfilter/nf_conntrack_h323_main.c b/net/netfilter/nf_conntrack_h323_main.c
index 8bb99b3..6d668af 100644
--- a/net/netfilter/nf_conntrack_h323_main.c
+++ b/net/netfilter/nf_conntrack_h323_main.c
@@ -977,30 +977,6 @@ static int process_alerting(struct sk_buff **pskb, struct nf_conn *ct,
}
/****************************************************************************/
-static int process_information(struct sk_buff **pskb,
- struct nf_conn *ct,
- enum ip_conntrack_info ctinfo,
- unsigned char **data, int dataoff,
- Information_UUIE *info)
-{
- int ret;
- int i;
-
- DEBUGP("nf_ct_q931: Information\n");
-
- if (info->options & eInformation_UUIE_fastStart) {
- for (i = 0; i < info->fastStart.count; i++) {
- ret = process_olc(pskb, ct, ctinfo, data, dataoff,
- &info->fastStart.item[i]);
- if (ret < 0)
- return -1;
- }
- }
-
- return 0;
-}
-
-/****************************************************************************/
static int process_facility(struct sk_buff **pskb, struct nf_conn *ct,
enum ip_conntrack_info ctinfo,
unsigned char **data, int dataoff,
@@ -1096,11 +1072,6 @@ static int process_q931(struct sk_buff **pskb, struct nf_conn *ct,
ret = process_alerting(pskb, ct, ctinfo, data, dataoff,
&pdu->h323_message_body.alerting);
break;
- case eH323_UU_PDU_h323_message_body_information:
- ret = process_information(pskb, ct, ctinfo, data, dataoff,
- &pdu->h323_message_body.
- information);
- break;
case eH323_UU_PDU_h323_message_body_facility:
ret = process_facility(pskb, ct, ctinfo, data, dataoff,
&pdu->h323_message_body.facility);
next prev parent reply other threads:[~2007-05-24 22:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-24 22:02 [NETFILTER 00/07]: Netfilter fixes Patrick McHardy
2007-05-24 22:02 ` [NETFILTER 01/07]: nf_conntrack_ftp: fix newline sequence number update Patrick McHardy
2007-05-24 23:41 ` David Miller
2007-05-24 22:02 ` [NETFILTER 02/07]: nf_conntrack_ftp: fix newline sequence number calculation Patrick McHardy
2007-05-24 23:41 ` David Miller
2007-05-24 22:02 ` [NETFILTER 03/07]: nf_conntrack_h323: fix ASN.1 types Patrick McHardy
2007-05-24 23:42 ` David Miller
2007-05-24 22:02 ` [NETFILTER 04/07]: nf_conntrack_h323: fix get_h225_addr() for IPv6 address access Patrick McHardy
2007-05-24 23:43 ` David Miller
2007-05-24 22:02 ` Patrick McHardy [this message]
2007-05-24 23:43 ` [NETFILTER 05/07]: nf_conntrack_h323: remove unnecessary process of Information signal David Miller
2007-05-24 22:02 ` [NETFILTER 06/07]: nf_conntrack_h323: add missing T.120 address in OLCA Patrick McHardy
2007-05-24 23:44 ` David Miller
2007-05-24 22:02 ` [NETFILTER 07/07]: nf_nat_h323: call set_h225_addr instead of set_h225_addr_hook Patrick McHardy
2007-05-24 23:44 ` David Miller
2007-05-24 23:45 ` [NETFILTER 00/07]: Netfilter fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070524215840.14308.13646.sendpatchset@localhost.localdomain \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.