All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: andrzej zaborowski <balrogg@gmail.com>
Cc: Linux OMAP ML <linux-omap-open-source@linux.omap.com>
Subject: Re: [PATCH] ARM: OMAP: Fix building with CONFIG_OMAP_GPIO_SWITCH off.
Date: Thu, 24 May 2007 17:34:30 -0700	[thread overview]
Message-ID: <20070525003430.GE19506@atomide.com> (raw)
In-Reply-To: <fb249edb0705221025s4447c7e1s2119e5a62ebb2198@mail.gmail.com>

* andrzej zaborowski <balrogg@gmail.com> [070522 10:26]:
> Define omap_register_gpio_switches when CONFIG_OMAP_GPIO_SWITCH is
> off. This will prevent adding a CONFIG_OMAP_GPIO_SWITCH check in the
> board files and enable building board-palmte.c with gpio-switch off.
> Also add __initdata to the two variables in gpio-switch that are used only
> during init.
>
> Signed-off-by: Andrzej Zaborowski <balrog@zabor.org>

> @@ -48,7 +49,12 @@ struct omap_gpio_switch {
>  };
>  
>  /* Call at init time only */
> -extern void omap_register_gpio_switches(const struct omap_gpio_switch *tbl,
> -					int count);
> +#ifdef CONFIG_OMAP_GPIO_SWITCH
> +extern void omap_register_gpio_switches(
> +		const struct omap_gpio_switch *tbl, int count);
> +#else
> +static inline void omap_register_gpio_switches(
> +		const struct omap_gpio_switch *tbl, int count) {}
> +#endif
>  
>  #endif
> -- 
> 1.4.4.3
> 

Can you please put the extern functions into a header file?
We got some comments on that on LKML few weeks ago.

Tony

  reply	other threads:[~2007-05-25  0:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-22 17:25 [PATCH] ARM: OMAP: Fix building with CONFIG_OMAP_GPIO_SWITCH off andrzej zaborowski
2007-05-25  0:34 ` Tony Lindgren [this message]
2007-05-27 12:57   ` andrzej zaborowski
2007-06-05 10:34     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070525003430.GE19506@atomide.com \
    --to=tony@atomide.com \
    --cc=balrogg@gmail.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.