From: "Shawn O. Pearce" <spearce@spearce.org>
To: Carlos Rica <jasampler@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <junkio@cox.net>
Subject: Re: [PATCH] fix memory leak in parse_object when check_sha1_signature fails
Date: Thu, 24 May 2007 22:09:39 -0400 [thread overview]
Message-ID: <20070525020939.GT28023@spearce.org> (raw)
In-Reply-To: <1b46aba20705241846u615785eeh7c3ebeaf840b2180@mail.gmail.com>
Carlos Rica <jasampler@gmail.com> wrote:
> When check_sha1_signature fails, program is not terminated:
> it prints an error message and returns NULL, so the
> buffer returned by read_sha1_file should be freed before.
...
> if (check_sha1_signature(sha1, buffer, size, typename(type))
> < 0) {
...
gmail strikes again. The above line is wrapped, which means your
patch is whitespace damaged and won't apply properly.
--
Shawn.
next prev parent reply other threads:[~2007-05-25 2:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-25 1:46 [PATCH] fix memory leak in parse_object when check_sha1_signature fails Carlos Rica
2007-05-25 2:09 ` Shawn O. Pearce [this message]
2007-05-25 2:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070525020939.GT28023@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=jasampler@gmail.com \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.