Re: [PATCH 3/3] mac80211: debugfs support for TSM and DLS

[Randy Dunlap <randy.dunlap@oracle.com>]

On Fri, 25 May 2007 19:52:44 +0800 Zhu Yi wrote:

>  net/mac80211/debugfs_netdev.c |  332 +++++++++++++++++++++++++++++++++++++++++
>  net/mac80211/ieee80211_i.h    |   33 ++++
>  2 files changed, 365 insertions(+), 0 deletions(-)
> 
> diff --git a/net/mac80211/debugfs_netdev.c b/net/mac80211/debugfs_netdev.c
> index 9e39646..e0f77f9 100644
> --- a/net/mac80211/debugfs_netdev.c
> +++ b/net/mac80211/debugfs_netdev.c

> +#define DEBUGFS_QOS_DEL(name)						\
> +	debugfs_remove(sdata->debugfs.sta.qos.name);			\
> +	sdata->debugfs.sta.qos.name = NULL;

Enclose multi-line macros inside braces, or even better, inside

	do {
		/* multi-lines */
	} while (0);


> +#define DEBUGFS_TSINFO_DEL(name)					\
> +	debugfs_remove(sdata->debugfs.sta.tsinfo.name);			\
> +	sdata->debugfs.sta.tsinfo.name = NULL;

ditto.

> +#define DEBUGFS_TSPEC_DEL(name)						\
> +	debugfs_remove(sdata->debugfs.sta.tspec.name);			\
> +	sdata->debugfs.sta.tspec.name = NULL;

ditto.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***