From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-mm@kvack.org, Mel Gorman <mel@csn.ul.ie>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
William Lee Irwin III <wli@holomorphy.com>
Subject: Re: [patch 0/6] Compound Page Enhancements
Date: Fri, 25 May 2007 10:14:11 -0700 [thread overview]
Message-ID: <20070525101411.a95bd2ea.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0705250701400.5490@schroedinger.engr.sgi.com>
On Fri, 25 May 2007 07:03:22 -0700 (PDT) Christoph Lameter <clameter@sgi.com> wrote:
> On Thu, 24 May 2007, Andrew Morton wrote:
>
> > And looking back on it, I don't see the point in that PG_head_tail_mask
> > hack either. We could have done
> >
> > static inline int page_tail(struct page *page)
> > {
> > return PageCompound(page) && (page->first_page != page);
> > }
>
> But then PageHead(page) wont work anymore. pagehead->first_page is in use
> for some other purpose.
That's only because slub came along and screwed it all up. The compound
page management used to be consistent, and simple.
Specifically: that lockless_freelist afterthought rendered us unable to fix
this mess.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-05-25 17:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-25 5:17 [patch 0/6] Compound Page Enhancements clameter
2007-05-25 5:17 ` [patch 1/6] Compound page handling enhancements clameter
2007-05-25 5:17 ` [patch 2/6] compound pages: Add new support functions clameter
2007-05-25 5:17 ` [patch 3/6] compound pages: vmstat support clameter
2007-05-25 5:17 ` [patch 4/6] compound pages: Use new compound vmstat functions in SLUB clameter
2007-05-25 5:17 ` [patch 5/6] compound pages: Allow use of get_page_unless_zero with compound pages clameter
2007-05-25 5:17 ` [patch 6/6] compound pages: Allow freeing of compound pages via pagevec clameter
2007-05-25 6:00 ` [patch 0/6] Compound Page Enhancements Andrew Morton
2007-05-25 13:54 ` Christoph Lameter
2007-05-25 14:03 ` Christoph Lameter
2007-05-25 17:14 ` Andrew Morton [this message]
2007-05-25 18:56 ` Christoph Lameter
2007-05-25 8:05 ` KAMEZAWA Hiroyuki
2007-05-25 13:42 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070525101411.a95bd2ea.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.