From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 25 May 2007 11:28:09 -0700 From: Stephen Hemminger Subject: Re: [Bridge] [BUG] Dropping fragmented IP packets within VLAN frames on bridge Message-ID: <20070525112809.68da124e@oldman> In-Reply-To: <20070525181705.5c20df89@zonk.pl> References: <20070525081750.5ba4a411@zonk.pl> <20070525085947.12841835@freepuppy> <20070525174925.41bd6b2e@zonk.pl> <20070525110013.1d2242e8@oldman> <20070525181705.5c20df89@zonk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Adam Osuchowski Cc: bridge@lists.linux-foundation.org On Fri, 25 May 2007 20:17:05 +0200 Adam Osuchowski wrote: > Stephen Hemminger wrote: > > There is a function in br_forward.c that handles VLAN packet length > > maybe use that > > Do you mean packet_length()? It is up to you, but IMHO it will only slow > down processing due to extra skb->protocol check. Your original code was calling ip_fragment for all VLAN tagged frames