From: Jean Delvare <khali@linux-fr.org>
To: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] tty_io: Use kzalloc
Date: Fri, 25 May 2007 12:42:58 +0200 [thread overview]
Message-ID: <20070525124258.5b72f077@hyperion.delvare> (raw)
Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
Andrew, can you please pick this? I couldn't find any maintainer for
this driver. Thanks.
drivers/char/tty_io.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
--- linux-2.6.22-rc2.orig/drivers/char/tty_io.c 2007-05-25 08:43:16.000000000 +0200
+++ linux-2.6.22-rc2/drivers/char/tty_io.c 2007-05-25 08:43:24.000000000 +0200
@@ -2009,11 +2009,10 @@ static int init_dev(struct tty_driver *d
}
if (!*ltp_loc) {
- ltp = (struct ktermios *) kmalloc(sizeof(struct ktermios),
+ ltp = (struct ktermios *) kzalloc(sizeof(struct ktermios),
GFP_KERNEL);
if (!ltp)
goto free_mem_out;
- memset(ltp, 0, sizeof(struct ktermios));
}
if (driver->type == TTY_DRIVER_TYPE_PTY) {
@@ -2043,10 +2042,9 @@ static int init_dev(struct tty_driver *d
if (!*o_ltp_loc) {
o_ltp = (struct ktermios *)
- kmalloc(sizeof(struct ktermios), GFP_KERNEL);
+ kzalloc(sizeof(struct ktermios), GFP_KERNEL);
if (!o_ltp)
goto free_mem_out;
- memset(o_ltp, 0, sizeof(struct ktermios));
}
/*
@@ -3732,9 +3730,8 @@ struct tty_driver *alloc_tty_driver(int
{
struct tty_driver *driver;
- driver = kmalloc(sizeof(struct tty_driver), GFP_KERNEL);
+ driver = kzalloc(sizeof(struct tty_driver), GFP_KERNEL);
if (driver) {
- memset(driver, 0, sizeof(struct tty_driver));
driver->magic = TTY_DRIVER_MAGIC;
driver->num = lines;
/* later we'll move allocation of tables here */
--
Jean Delvare
next reply other threads:[~2007-05-25 10:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-25 10:42 Jean Delvare [this message]
2007-05-25 10:45 ` [PATCH] tty_io: Use kzalloc Pekka Enberg
2007-05-25 11:43 ` Jean Delvare
2007-05-25 11:45 ` [PATCH v2] " Jean Delvare
2007-05-25 10:46 ` [PATCH] " Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070525124258.5b72f077@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.