From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [PATCH] hwmon-vid: Don't spam the logs when VRM
Date: Fri, 25 May 2007 12:15:52 +0000 [thread overview]
Message-ID: <20070525141552.694337fc@hyperion.delvare> (raw)
If we cannot guess which VRM version the CPU uses, we set it to 0 and
log it. So we shouldn't spam the log each time vid_from_reg() is
later called with vrm 0.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Rudolf Marek <r.marek@assembler.cz>
---
Rudolf, is it OK with you? Please ack or nack.
drivers/hwmon/hwmon-vid.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- linux-2.6.22-rc2.orig/drivers/hwmon/hwmon-vid.c 2007-05-13 10:01:15.000000000 +0200
+++ linux-2.6.22-rc2/drivers/hwmon/hwmon-vid.c 2007-05-25 14:09:55.000000000 +0200
@@ -132,7 +132,9 @@ int vid_from_reg(int val, u8 vrm)
val &= 0x7f;
return(val > 0x77 ? 0 : (1500000 - (val * 12500) + 500) / 1000);
default: /* report 0 for unknown */
- printk(KERN_INFO "hwmon-vid: requested unknown VRM version\n");
+ if (vrm)
+ printk(KERN_WARNING "hwmon-vid: requested unknown "
+ "VRM version (%u)\n", (unsigned int)vrm);
return 0;
}
}
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next reply other threads:[~2007-05-25 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-25 12:15 Jean Delvare [this message]
2007-05-25 12:17 ` [lm-sensors] [PATCH] hwmon-vid: Don't spam the logs when VRM Rudolf Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070525141552.694337fc@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.