From: Khem Raj <kraj@mvista.com>
To: linux-omap-open-source@linux.omap.com
Cc: Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH 16/18] omap2: convert DSP code to use new PRCM functions & defines
Date: Fri, 25 May 2007 14:32:43 -0700 [thread overview]
Message-ID: <200705251432.44056.kraj@mvista.com> (raw)
In-Reply-To: <20070517005444.675356053@pwsan.com>
On Wednesday 16 May 2007 17:11:48 Paul Walmsley wrote:
> Convert the OMAP2-specific code in plat-omap/dsp to use the new PRCM
> read/write functions and symbolic constants for registers and register
> bits.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> ---
> arch/arm/plat-omap/dsp/dsp_common.h | 39
> ++++++++++++++++++++++++++--------- arch/arm/plat-omap/dsp/omap2_dsp.h |
> 1 -
> 2 files changed, 29 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm/plat-omap/dsp/dsp_common.h
> b/arch/arm/plat-omap/dsp/dsp_common.h index 898c9ea..2369dad 100644
> --- a/arch/arm/plat-omap/dsp/dsp_common.h
> +++ b/arch/arm/plat-omap/dsp/dsp_common.h
> @@ -28,6 +28,11 @@
> #include <asm/arch/mmu.h>
> #include "hardware_dsp.h"
>
> +#include "../../mach-omap2/prm.h"
> +#include "../../mach-omap2/prm_regbits_24xx.h"
> +#include "../../mach-omap2/cm.h"
> +#include "../../mach-omap2/cm_regbits_24xx.h"
> +
I think the above includes will break OMAP1. Shouldn't they be included
conditionally in
#ifdef CONFIG_ARCH_OMAP2
#endif
next prev parent reply other threads:[~2007-05-25 21:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-17 0:11 [PATCH 00/18] PRCM cleanup - remove prcm-regs.h Paul Walmsley
2007-05-17 0:11 ` [PATCH 01/18] omap2: add OMAP24XX and OMAP2/3 modules to prcm_common.h Paul Walmsley
2007-05-17 0:11 ` [PATCH 02/18] omap2: add OMAP24XX register bit defines shared between CM and PRM Paul Walmsley
2007-05-17 0:11 ` [PATCH 03/18] omap2: add OMAP24XX Clock Management register defines Paul Walmsley
2007-05-17 0:11 ` [PATCH 04/18] omap2: add Clock Management shared register bit defines to cm.h Paul Walmsley
2007-05-17 0:11 ` [PATCH 05/18] omap2: add OMAP24XX Power/Reset Management register defines Paul Walmsley
2007-05-17 0:11 ` [PATCH 06/18] omap2: add Power/Reset Management shared register bit defines to prm.h Paul Walmsley
2007-05-17 0:11 ` [PATCH 07/18] omap2: add OMAP24XX Clock Management register bit defines Paul Walmsley
2007-05-17 0:11 ` [PATCH 08/18] omap2: add OMAP24XX Power/Reset " Paul Walmsley
2007-05-17 0:11 ` [PATCH 09/18] omap2: add PRM_BASE/CM_BASE #defines Paul Walmsley
2007-05-17 0:11 ` [PATCH 10/18] omap2: convert pm.c to use new PRCM functions and symbolic constants Paul Walmsley
2007-05-17 0:11 ` [PATCH 11/18] omap2: convert clock.c " Paul Walmsley
2007-05-17 0:11 ` [PATCH 12/18] omap2: convert prcm.c to use symbolic register & register bit constants Paul Walmsley
2007-05-17 0:11 ` [PATCH 13/18] omap2: convert sram-fn.S to use {PRM, CM}_BASE rather than PRCM_BASE Paul Walmsley
2007-05-17 0:11 ` [PATCH 14/18] omap2: convert clock.h to use symbolic register defines Paul Walmsley
2007-05-17 0:11 ` [PATCH 15/18] omap2: convert clock.h to use symbolic register bit defines Paul Walmsley
2007-05-17 0:11 ` [PATCH 16/18] omap2: convert DSP code to use new PRCM functions & defines Paul Walmsley
2007-05-25 21:32 ` Khem Raj [this message]
2007-05-17 0:11 ` [PATCH 17/18] omap2: remove remaining prcm-regs.h includes Paul Walmsley
2007-05-17 0:11 ` [PATCH 18/18] omap2: remove prcm-regs.h Paul Walmsley
-- strict thread matches above, loose matches on Subject: below --
2007-05-25 8:23 [PATCH 00/18] PRCM cleanup - " Paul Walmsley
2007-05-25 8:23 ` [PATCH 16/18] omap2: convert DSP code to use new PRCM functions & defines Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705251432.44056.kraj@mvista.com \
--to=kraj@mvista.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.